Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gasLimitOverMaxGasLimitFailsPrecheck and createGasLimitOverMaxGasLimitFailsPrecheck #9877

Merged
merged 8 commits into from Nov 15, 2023
Merged

Fix gasLimitOverMaxGasLimitFailsPrecheck and createGasLimitOverMaxGasLimitFailsPrecheck #9877

merged 8 commits into from Nov 15, 2023

Conversation

MrValioBg
Copy link
Contributor

@MrValioBg MrValioBg commented Nov 14, 2023 •
edited

Description:
The checks for MAX_GAS_LIMIT_EXCEEDED already exist in HevmTransactionFactory but its not pre-consensus like in mono. So in order to enable it to work in modular we add the ResponseCode in the spec.streamlinedIngestChecks property

Related issue(s):

Fixes #9401

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@MrValioBg
init: initial commit fixing contract call & create max_gas tests
90b7ad2 
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
@MrValioBg MrValioBg changed the title Fix gasLimitOverMaxGasLimitFailsPrecheck and createGasLimitOverMaxGasLimitFailsPrecheck in LeakyContractTestsSuite Fix gasLimitOverMaxGasLimitFailsPrecheck and createGasLimitOverMaxGasLimitFailsPrecheck in LeakyContractTestsSuite Nov 14, 2023
@MrValioBg MrValioBg changed the title Fix gasLimitOverMaxGasLimitFailsPrecheck and createGasLimitOverMaxGasLimitFailsPrecheck in LeakyContractTestsSuite Fix gasLimitOverMaxGasLimitFailsPrecheck and createGasLimitOverMaxGasLimitFailsPrecheck Nov 14, 2023
@MrValioBg MrValioBg self-assigned this Nov 14, 2023
@MrValioBg MrValioBg added the Limechain Work planned for the LimeChain team label Nov 14, 2023
@MrValioBg
tests: disable autoAssociationSlotsAppearsInInfo
c8a699a 
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
@MrValioBg
refactor: spotless apply
e1794b9 
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited

Node: Unit Test Results

    2 280 files  +  3      2 280 suites  +3   1h 28m 33s ⏱️ + 3m 35s
118 363 tests +37  118 329 ✔️ +37  34 💤 ±0  0 ❌ ±0 
126 627 runs  +39  126 593 ✔️ +39  34 💤 ±0  0 ❌ ±0 

Results for commit 2d0ebdd. ± Comparison against base commit a756738.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 40s ⏱️ + 21m 40s
312 tests +311  312 ✔️ +312  0 💤 ±0  0 ❌  - 1 
334 runs  +333  334 ✔️ +334  0 💤 ±0  0 ❌  - 1 

Results for commit 2d0ebdd. ± Comparison against base commit a756738.

This pull request removes 1 and adds 312 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 35s ⏱️ +8s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 2d0ebdd. ± Comparison against base commit a756738.

♻️ This comment has been updated with latest results.

@MrValioBg
refactor: fix wrong check
6b64aff 
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
@MrValioBg
refactor: use different approach to fixing tests. Now we don't modify…
7bc6298 
… the code, but make the test support both statuses from mono & mod since both are correct

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
@MrValioBg
refactor: revert wrong check
1ffdd60 
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
@MrValioBg
refactor: spotless apply
6d3cd58 
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
@MrValioBg
refactor: the same approach, but use spec.streamlinedIngestChecks opt…
2d0ebdd 
…ion.

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
@MrValioBg MrValioBg marked this pull request as ready for review November 15, 2023 08:52
@MrValioBg MrValioBg requested review from a team as code owners November 15, 2023 08:52
@github-actions GitHub Actions
Copy link

Node: HAPI Test Results

1 246 tests  ±0   881 ✔️ +8   1h 28m 2s ⏱️ + 2m 38s
   166 suites ±0   365 💤  - 8 
   166 files   ±0       0 ❌ ±0 

Results for commit 2d0ebdd. ± Comparison against base commit a756738.

tinker-michaelj
tinker-michaelj approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@tinker-michaelj tinker-michaelj merged commit 2226efb into develop Nov 15, 2023
14 of 15 checks passed
@tinker-michaelj tinker-michaelj deleted the 09401-fix-max-gas-fees-contract-operations-tests branch November 15, 2023 16:13
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@MrValioBg @nickpoorman
Fix gasLimitOverMaxGasLimitFailsPrecheck and `createGasLimitOverMax…
52ebf1a 
…GasLimitFailsPrecheck` (#9877)

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@rbair23 rbair23 Awaiting requested review from rbair23 rbair23 is a code owner automatically assigned from hashgraph/hedera-base

@iwsimon iwsimon Awaiting requested review from iwsimon iwsimon is a code owner automatically assigned from hashgraph/hedera-services

Assignees

@MrValioBg MrValioBg

Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix gasLimitOverMaxGasLimitFailsPrecheck, createGasLimitOverMaxGasLimitFailsPrecheck tests
2 participants
@MrValioBg @tinker-michaelj