Fix race condition in PCES file copy. #9890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <cody@swirldslabs.com>
cody-littley
requested review from
lpetrovic05,
alittley and
edward-swirldslabs
edward-swirldslabs
previously approved these changes
Nov 14, 2023
alittley
previously approved these changes
Nov 14, 2023
...lds-platform-core/src/main/java/com/swirlds/platform/state/signed/SignedStateFileWriter.java
Outdated
Show resolved
Hide resolved
...lds-platform-core/src/main/java/com/swirlds/platform/state/signed/SignedStateFileWriter.java
Outdated
Show resolved
Hide resolved
Node: E2E Test Results 1 files ± 0 1 suites ±0 22m 33s ⏱️ + 22m 33s Results for commit 54ca45d. ± Comparison against base commit 9bf77c0. This pull request removes 1 and adds 312 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Cody Littley <cody@swirldslabs.com>
cody-littley
dismissed stale reviews from alittley and edward-swirldslabs
via
54ca45d
alittley
approved these changes
Nov 14, 2023
lpetrovic05
reviewed
Nov 15, 2023
...lds-platform-core/src/main/java/com/swirlds/platform/state/signed/SignedStateFileWriter.java
Show resolved
Hide resolved
lpetrovic05
approved these changes
Nov 15, 2023
cody-littley
added a commit
that referenced
this pull request
Nov 15, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
poulok
pushed a commit
that referenced
this pull request
Nov 16, 2023
nickpoorman
pushed a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9883
Needs to be cherry picked into 0.44