Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

09837 9578 advanced wire transformers #9894

Merged
merged 38 commits into from Nov 15, 2023
Merged

09837 9578 advanced wire transformers #9894

merged 38 commits into from Nov 15, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #9837

Must be merged after #9835

@cody-littley
Added heartbeats to wiring framework.
ee13cf3 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
New tests, fixed bugs.
c19c01b 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Added offer soldering.
d3b216e 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Added direct task scheduler.
bc15c50 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress fitting direct schedulers into the wiring model.
45e549d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental changes.
db3735b 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 09618-heartbeats
c282ebc 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch '09618-heartbeats' into 09670-9618-offer-solder
561483e 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
07f3760 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch '09670-9618-offer-solder' into 09665-9670-direct-scheduler
be02775 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress.
498f4b5 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 09665-9670-direct-scheduler
d7a5e64 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Minor changes.
83cccf3 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress.
cbafb57 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 09665-9670-direct-scheduler
bb6d0a0 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Added unit tests.
dd07b4a 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
9829ff7 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Create SEQENTIAL_THREAD scheduler.
0844963 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Simplify wiring model inheritence.
9dec554 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Cleanup.
301ec6d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Cleanup.
54bd257 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested change.
7565855 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 09665-9670-direct-scheduler
9dc66a6 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch '09665-9670-direct-scheduler' into 09578-9665-sequential…
e3a94ef 
…-thread-scheduler

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Bugfixes, made suggested changes
f60820e 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
06d221d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch '09665-9670-direct-scheduler' into 09578-9665-sequential…
6cecc7f 
…-thread-scheduler

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 09578-9665-sequential-thread-scheduler
2be48e4 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested change.
aba9331 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed test flake.
3689197 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley self-assigned this Nov 14, 2023
@cody-littley cody-littley requested review from a team as code owners November 14, 2023 20:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 56s ⏱️ + 21m 56s
312 tests +311  312 ✔️ +312  0 💤 ±0  0 ❌  - 1 
334 runs  +333  334 ✔️ +334  0 💤 ±0  0 ❌  - 1 

Results for commit 89aa4a5. ± Comparison against base commit 6cc526c.

This pull request removes 1 and adds 312 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 24s ⏱️ +8s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 89aa4a5. ± Comparison against base commit 6cc526c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited

Node: HAPI Test Results

1 246 tests   879 ✔️  1h 29m 29s ⏱️
   166 suites  367 💤
   166 files        0 ❌

Results for commit dbd02d9.

♻️ This comment has been updated with latest results.

lpetrovic05
lpetrovic05 previously approved these changes Nov 15, 2023
View reviewed changes
Base automatically changed from 09578-9665-sequential-thread-scheduler to develop November 15, 2023 14:06
@cody-littley cody-littley dismissed lpetrovic05’s stale review November 15, 2023 14:06

The base branch was changed.

@cody-littley
Merge branch 'develop' into 09837-9578-wire-mutator
0f1f6fd 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
dbd02d9 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

Node: Unit Test Results

    2 280 files  ±0      2 280 suites  ±0   1h 29m 13s ⏱️ + 1m 22s
118 339 tests +3  118 305 ✔️ +3  34 💤 ±0  0 ❌ ±0 
126 657 runs  +3  126 623 ✔️ +3  34 💤 ±0  0 ❌ ±0 

Results for commit 89aa4a5. ± Comparison against base commit 6cc526c.

♻️ This comment has been updated with latest results.

@cody-littley
Made suggested changes.
89aa4a5 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley merged commit 649ea48 into develop Nov 15, 2023
13 of 14 checks passed
@cody-littley cody-littley deleted the 09837-9578-wire-mutator branch November 15, 2023 17:46
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@cody-littley @nickpoorman
09837 9578 advanced wire transformers (#9894)
f12c5f3 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alittley alittley alittley approved these changes

@lpetrovic05 lpetrovic05 lpetrovic05 left review comments

@edward-swirldslabs edward-swirldslabs Awaiting requested review from edward-swirldslabs

@deepak-swirlds deepak-swirlds Awaiting requested review from deepak-swirlds deepak-swirlds is a code owner automatically assigned from hashgraph/release-engineering

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

@hendrikebbers hendrikebbers Awaiting requested review from hendrikebbers hendrikebbers is a code owner automatically assigned from hashgraph/platform-base

@artemananiev artemananiev Awaiting requested review from artemananiev artemananiev is a code owner automatically assigned from hashgraph/platform-data

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
v0.45
Development

Successfully merging this pull request may close these issues.

Wiring framework: support for state reservation lifecycle
3 participants
@cody-littley @lpetrovic05 @alittley