Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate and fix fuzzy records in HollowAccountFinalizationSuite #9904

Merged
merged 132 commits into from
Nov 17, 2023
Merged

Validate and fix fuzzy records in HollowAccountFinalizationSuite #9904

merged 132 commits into from
Nov 17, 2023

Conversation

Neeharika-Sompalli
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli commented Nov 15, 2023 •
edited
Loading

Fixes #9696

Description

  • Adds CallOutcome#recipientId to match mono-service logic for setting the called ContractID in the receipt of even a ContractCall or EthereumTransaction.
  • Adds HandleException#shouldRollbackStack to let contract operations suppress the HandleWorkflow rollback their gas charges. (Note: Once we rationalize contract fee charging this can be removed.)
  • Updates CryptoUpdateRecordBuilder.accountId only for hollow account finalizations
  • Skips verifying keys for a hollow payer
  • Adds optionalKeys set to preHandleResult. Changed HandleWorkflow#haveKeyChanges to looks at the preHandleResult.requiredKeys() and preHandleResult.optionalKeys()
  • Adds calculateFees for ContractCreateHandler
  • Ensures royalty fallback fee is charged only once per tokenId

tinker-michaelj and others added 30 commits November 3, 2023 11:46
@tinker-michaelj
Stabilize fuzzy matching
3361ca0 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Try to stabilize CI
4f8c0d2 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Remove fuzzy match from PayableCreate2WorksAsExpected() for now
824277d 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Add AutoSnapshotModeOp
4bc440c 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Stabilize CryptoTransferSuite
9ecc4ba 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Skip irrelevant files
eaa0fcb 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Merge upstream
abfd631 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Small fixes
9f5dd85 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Consolidate JSON snapshots
730c0c4 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Stabilize CI
e56d85c 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Merge remote-tracking branch 'origin/develop' into 09697-auto-snapsho…
874935a 
…t-matching
@tinker-michaelj
Add resouce
848aa92 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@Neeharika-Sompalli
wip
1a69bdd
@Neeharika-Sompalli
Merge branch '09697-auto-snapshot-matching' into 9750-D-transfer-fuzz…
14eb340 
…y-records
@Neeharika-Sompalli
wip
7a7e402
@Neeharika-Sompalli
wip
3d69063
@Neeharika-Sompalli
Merge branch 'develop' into 9750-D-transfer-fuzzy-records
d10ba68
@MiroslavGatsanoga
Fix some tests from LazyCreateThroughPrecompileSuite
6653952 
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga
Extract setting of contract call result in record to be in precompile…
e28e34c 
… call

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@tinker-michaelj
Add gas fees to ContractCreate and ContractCall record transactionFee…
fd1d0e9 
… fields

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Merge remote-tracking branch 'origin/develop' into 09663-inc-gas-in-t…
0f50b2b 
…xn-fee
@tinker-michaelj
Revert HtsCall change
fe55ec7 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Remove unwanted log
207b036 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Fix typo
6837011 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@Neeharika-Sompalli
fixes few more issues
d5a7482
@tinker-michaelj
fix unit test
dd7619d 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@Neeharika-Sompalli
fixes few more issues
1954f9b
@Neeharika-Sompalli
Merge remote-tracking branch 'origin/09663-inc-gas-in-txn-fee' into 9…
9c3ea2f 
…750-D-transfer-fuzzy-records
@tinker-michaelj
intermezzo
057efd7 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Add unit tests, prep for PR
7ec4e2d 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@Neeharika-Sompalli Neeharika-Sompalli marked this pull request as ready for review November 16, 2023 23:53
tinker-michaelj
tinker-michaelj previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @Neeharika-Sompalli !

@tinker-michaelj tinker-michaelj mentioned this pull request Nov 17, 2023
Merged
tinker-michaelj
tinker-michaelj previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iwsimon
iwsimon approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes! LGTM.

tinker-michaelj
tinker-michaelj approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Neeharika-Sompalli Neeharika-Sompalli merged commit 791ab23 into develop Nov 17, 2023
14 of 15 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 9696-hollow-account-records branch November 17, 2023 20:56
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@Neeharika-Sompalli @tinker-michaelj
@MiroslavGatsanoga @nickpoorman
Validate and fix fuzzy records in HollowAccountFinalizationSuite (#…
b94e9bc 
…9904)

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com>
Co-authored-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@mhess-swl mhess-swl mhess-swl approved these changes

@iwsimon iwsimon iwsimon approved these changes

Assignees

@Neeharika-Sompalli Neeharika-Sompalli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fuzzy match records with mono-service for HollowAccountFinalizationSuite
5 participants
@Neeharika-Sompalli @tinker-michaelj @mhess-swl @iwsimon @MiroslavGatsanoga