Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: roster change objects #9908

Merged
merged 10 commits into from Dec 4, 2023
Merged

feat: roster change objects #9908

merged 10 commits into from Dec 4, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #9907

@cody-littley
Create objects that will be used to communicate a change in roster.
e6ef9d0 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

Node: Unit Test Results

    2 290 files  +1      2 290 suites  +1   40m 13s ⏱️ - 9m 32s
118 410 tests +2  118 376 ✔️ +2  34 💤 ±0  0 ❌ ±0 
126 832 runs  +2  126 798 ✔️ +2  34 💤 ±0  0 ❌ ±0 

Results for commit cad0320. ± Comparison against base commit 0a9d531.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   23m 47s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit cad0320.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 33s ⏱️ -1s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit cad0320. ± Comparison against base commit 0a9d531.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Node: HAPI Test Results

1 246 tests   882 ✔️  1h 29m 26s ⏱️
   166 suites  363 💤
   166 files        1 ❌

For more details on these failures, see this check.

Results for commit e6ef9d0.

@cody-littley
Tweaks.
59189f6 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Play around with data structures.
4ebb81d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Created roster diff utility.
22e74ad 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Started writing unit test, does not pass yet.
fb27545 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
checkin
c29e3aa 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed unit test.
c039aee 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Cleanup.
24e20f8 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley marked this pull request as ready for review November 22, 2023 16:07
@cody-littley cody-littley requested a review from a team as a code owner November 22, 2023 16:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  24m 58s ⏱️
  2 suites  12 💤
  2 files      0 ❌

Results for commit cad0320.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited

Node: HAPI Test (Token) Results

190 tests   188 ✔️  20m 15s ⏱️
  13 suites      2 💤
  13 files        0 ❌

Results for commit cad0320.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  17m 41s ⏱️
  22 suites    10 💤
  22 files        0 ❌

Results for commit cad0320.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited

Node: HAPI Test (Misc) Results

419 tests  ±0   313 ✔️ ±0   24m 42s ⏱️ +28s
  73 suites ±0   106 💤 ±0 
  73 files   ±0       0 ❌ ±0 

Results for commit cad0320. ± Comparison against base commit 0a9d531.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited

Node: HAPI Test (Smart Contract) Results

405 tests   325 ✔️  44m 44s ⏱️
  56 suites    80 💤
  56 files        0 ❌

Results for commit b0a7ade.

♻️ This comment has been updated with latest results.

@cody-littley cody-littley added this to the v0.46 milestone Dec 1, 2023
@cody-littley
Made suggested changes.
b0a7ade 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@0a9d531). Click here to learn what that means.

❗ Current head b0a7ade differs from pull request most recent head cad0320. Consider uploading reports for the commit cad0320 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #9908   +/-   ##
==========================================
  Coverage           ?   63.15%           
  Complexity         ?    30709           
==========================================
  Files              ?     3332           
  Lines              ?   133991           
  Branches           ?    13892           
==========================================
  Hits               ?    84618           
  Misses             ?    46032           
  Partials           ?     3341

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cody-littley cody-littley changed the title Create objects that will be used to communicate a change in roster. feat: roster change objects Dec 4, 2023
@cody-littley cody-littley merged commit b9108aa into develop Dec 4, 2023
23 of 24 checks passed
@cody-littley cody-littley deleted the 09907-roster-change-objects branch December 4, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpetrovic05 lpetrovic05 lpetrovic05 left review comments

@alittley alittley alittley approved these changes

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.46
Development

Successfully merging this pull request may close these issues.

Create objects for communicating a change in roster
4 participants
@cody-littley @lpetrovic05 @alittley @edward-swirldslabs