Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9910 Introduce config-extensions module #9911

Merged
merged 3 commits into from Nov 16, 2023
Merged

#9910 Introduce config-extensions module #9911

merged 3 commits into from Nov 16, 2023

Conversation

timo0
Copy link
Member

@timo0 timo0 commented Nov 15, 2023

Fix #9910

@timo0
#9910 Introduce config-extensions module
a5ffbed 
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 requested review from a team as code owners November 15, 2023 17:43
@timo0 timo0 self-assigned this Nov 15, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

Node: Unit Test Results

    2 280 files  ±0      2 280 suites  ±0   1h 28m 0s ⏱️ -21s
118 339 tests +3  118 305 ✔️ +3  34 💤 ±0  0 ❌ ±0 
126 657 runs  +3  126 623 ✔️ +3  34 💤 ±0  0 ❌ ±0 

Results for commit 1d68893. ± Comparison against base commit f00aa3c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   21m 34s ⏱️
312 tests 312 ✔️ 0 💤 0 ❌
334 runs  334 ✔️ 0 💤 0 ❌

Results for commit 1d68893.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

Node: Integration Test Results

280 tests   280 ✔️  28m 34s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit 1d68893.

♻️ This comment has been updated with latest results.

@timo0
#9910 Move resources to new package
eb3400e 
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

Node: HAPI Test Results

1 246 tests   885 ✔️  1h 24m 53s ⏱️
   166 suites  361 💤
   166 files        0 ❌

Results for commit 1d68893.

♻️ This comment has been updated with latest results.

@timo0
#9910 Move resources to new package
1d68893 
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 mentioned this pull request Nov 16, 2023
Closed
povolev15
povolev15 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timo0 timo0 added this to the v0.45 milestone Nov 16, 2023
@timo0 timo0 merged commit 1fd9fd3 into develop Nov 16, 2023
14 of 15 checks passed
@timo0 timo0 deleted the 09910-d-introduce-config-extensions-module branch November 16, 2023 17:23
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@timo0 @nickpoorman
#9910 Introduce config-extensions module (#9911)
6380827 
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimbor kimbor kimbor approved these changes

@imalygin imalygin imalygin approved these changes

@netopyr netopyr netopyr approved these changes

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@hendrikebbers hendrikebbers hendrikebbers approved these changes

@povolev15 povolev15 povolev15 approved these changes

@alittley alittley alittley approved these changes

@deepak-swirlds deepak-swirlds Awaiting requested review from deepak-swirlds deepak-swirlds is a code owner automatically assigned from hashgraph/release-engineering

@poulok poulok Awaiting requested review from poulok poulok is a code owner automatically assigned from hashgraph/platform-hashgraph

@OlegMazurov OlegMazurov Awaiting requested review from OlegMazurov OlegMazurov is a code owner automatically assigned from hashgraph/platform-architects

@rbair23 rbair23 Awaiting requested review from rbair23 rbair23 is a code owner automatically assigned from hashgraph/hedera-base

@mhess-swl mhess-swl Awaiting requested review from mhess-swl mhess-swl is a code owner automatically assigned from hashgraph/hedera-services

Assignees

@timo0 timo0

Labels
None yet
Projects
None yet
Milestone
v0.45
Development

Successfully merging this pull request may close these issues.

Move config sources from swirlds-common to a new module
8 participants
@timo0 @kimbor @imalygin @netopyr @jeromy-cannon @hendrikebbers @povolev15 @alittley