Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule create specs #9914

Merged
merged 20 commits into from Nov 17, 2023
Merged

schedule create specs #9914

merged 20 commits into from Nov 17, 2023

Conversation

povolev15
Copy link
Contributor

@povolev15 povolev15 commented Nov 15, 2023

Fix 4 tests that are related to the schedule create

Fixes #9719

Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15 povolev15 self-assigned this Nov 15, 2023
@povolev15 povolev15 requested review from a team as code owners November 15, 2023 19:54
jsync-swirlds
jsync-swirlds previously approved these changes Nov 15, 2023
mhess-swl
mhess-swl previously approved these changes Nov 15, 2023
Copy link

github-actions bot commented Nov 15, 2023

Node: Unit Test Results

    2 281 files  ±0      2 281 suites  ±0   1h 26m 16s ⏱️ +24s
118 353 tests ±0  118 319 ✔️ ±0  34 💤 ±0  0 ±0 
126 671 runs  ±0  126 637 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 9c0ea74. ± Comparison against base commit 1dc870e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 15, 2023

Node: E2E Test Results

    1 files      1 suites   22m 3s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 9c0ea74.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 15, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 25s ⏱️ +13s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 9c0ea74. ± Comparison against base commit 1dc870e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 15, 2023

Node: HAPI Test Results

1 247 tests   908 ✔️  1h 31m 17s ⏱️
   166 suites  338 💤
   166 files        1

For more details on these failures, see this check.

Results for commit 9c0ea74.

♻️ This comment has been updated with latest results.

kimbor
kimbor previously approved these changes Nov 15, 2023
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@1dc870e). Click here to learn what that means.

❗ Current head 598e0ea differs from pull request most recent head 9c0ea74. Consider uploading reports for the commit 9c0ea74 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             develop   #9914   +/-   ##
=========================================
  Coverage           ?       0           
=========================================
  Files              ?       0           
  Lines              ?       0           
  Branches           ?       0           
=========================================
  Hits               ?       0           
  Misses             ?       0           
  Partials           ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@povolev15 povolev15 changed the title schedule create specs (5 test) schedule create specs and ExecutionSpec (7 test) Nov 16, 2023
mhess-swl
mhess-swl previously approved these changes Nov 16, 2023
Copy link
Member

@mhess-swl mhess-swl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsync-swirlds
jsync-swirlds previously approved these changes Nov 16, 2023
jsync-swirlds
jsync-swirlds previously approved these changes Nov 16, 2023
mhess-swl
mhess-swl previously approved these changes Nov 16, 2023
@kimbor kimbor changed the title schedule create specs and ExecutionSpec (7 test) schedule create specs Nov 16, 2023
@povolev15 povolev15 merged commit 0c6e4bb into develop Nov 17, 2023
12 of 15 checks passed
@povolev15 povolev15 deleted the 9719-ScheduleCreateSpecs branch November 17, 2023 15:48
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Lev Povolotsky <16233475+povolev15@users.noreply.github.com>
Co-authored-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix remaining ScheduleCreate tests
4 participants