Fix ScheduleSignHandler signature trim and verification building #9920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsync-swirlds
force-pushed
the
09869-ScheduleSignHandler-signature-verification
branch
2 times, most recently
from
78175c9
to
086df14
Compare
jsync-swirlds
force-pushed
the
09869-ScheduleSignHandler-signature-verification
branch
2 times, most recently
from
a921742
to
f099c77
Compare
jsync-swirlds
force-pushed
the
09869-ScheduleSignHandler-signature-verification
branch
from
f099c77
to
28224b3
Compare
iwsimon
reviewed
Nov 16, 2023
...ce-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtility.java
Show resolved
Hide resolved
iwsimon
reviewed
Nov 16, 2023
.../src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleCreateHandler.java
Show resolved
Hide resolved
iwsimon
reviewed
Nov 16, 2023
...de/test-clients/src/main/java/com/hedera/services/bdd/suites/schedule/ScheduleSignSpecs.java
Show resolved
Hide resolved
iwsimon
reviewed
Nov 16, 2023
...ce-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtility.java
Show resolved
Hide resolved
* Fixed some general signature verification and record building issues previously identified * Changed the trim to walk the key structure for required keys, rather than attempting a direct match (which will often fail incorrectly) in trim * Added check in SignHandler to throw exception if a ScheduleSign transaction does not result in a change to signatories, or execution. * Enabled 17 HapiTest specs in ScheduleSignSpecs. Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
jsync-swirlds
force-pushed
the
09869-ScheduleSignHandler-signature-verification
branch
from
28224b3
to
7c3f5f7
Compare
jsync-swirlds
deleted the
09869-ScheduleSignHandler-signature-verification
branch
nickpoorman
pushed a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9869