Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @Tag annotation on a class level #9927

Merged
merged 3 commits into from Nov 16, 2023
Merged

Support @Tag annotation on a class level #9927

merged 3 commits into from Nov 16, 2023

Conversation

vtronkov
Copy link
Contributor

Description:
Add @tag support on class-level

Related issue(s):

Fixes #9926

@vtronkov
feature: add class-level tag support
4581bd2 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
nit: spotless
e137310 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov vtronkov added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Nov 16, 2023
@vtronkov vtronkov self-assigned this Nov 16, 2023
@vtronkov vtronkov marked this pull request as ready for review November 16, 2023 10:27
@vtronkov vtronkov requested review from a team as code owners November 16, 2023 10:27
@vtronkov
refactor: rename param
cd1c9e9 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
netopyr
netopyr approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Node: Unit Test Results

    2 280 files  ±0      2 280 suites  ±0   1h 26m 48s ⏱️ + 2m 7s
118 339 tests ±0  118 305 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
126 657 runs  ±0  126 623 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit cd1c9e9. ± Comparison against base commit 761ce07.

@github-actions GitHub Actions
Copy link

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 50s ⏱️ + 21m 50s
312 tests +311  312 ✔️ +312  0 💤 ±0  0 ❌  - 1 
334 runs  +333  334 ✔️ +334  0 💤 ±0  0 ❌  - 1 

Results for commit cd1c9e9. ± Comparison against base commit 761ce07.

This pull request removes 1 and adds 312 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

@github-actions GitHub Actions
Copy link

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 13s ⏱️ -21s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit cd1c9e9. ± Comparison against base commit 761ce07.

@github-actions GitHub Actions
Copy link

Node: HAPI Test Results

1 246 tests  ±0   885 ✔️ ±0   1h 24m 25s ⏱️ - 7m 25s
   166 suites ±0   361 💤 ±0 
   166 files   ±0       0 ❌ ±0 

Results for commit cd1c9e9. ± Comparison against base commit 761ce07.

@vtronkov vtronkov merged commit 97cddcc into develop Nov 16, 2023
14 of 15 checks passed
@vtronkov vtronkov deleted the 09926-support-tag-annotation-on-class-level branch November 16, 2023 12:53
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@vtronkov @nickpoorman
Support @tag annotation on a class level (#9927)
766dc33 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netopyr netopyr netopyr approved these changes

Assignees

@vtronkov vtronkov

Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support @Tag annotation on a class level
2 participants
@vtronkov @netopyr