Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed HollowAccountCompletionFuzzing #9947

Merged
merged 7 commits into from Nov 17, 2023

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented Nov 16, 2023

Description:

Related issue(s):

Fixes #9505

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
@iwsimon iwsimon requested review from a team as code owners November 16, 2023 22:03
@iwsimon iwsimon self-assigned this Nov 16, 2023
Copy link

github-actions bot commented Nov 16, 2023

Node: Unit Test Results

    2 281 files  ±0      2 281 suites  ±0   1h 24m 32s ⏱️ - 1m 52s
118 353 tests ±0  118 319 ✔️ ±0  34 💤 ±0  0 ±0 
126 671 runs  ±0  126 637 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 5613408. ± Comparison against base commit 87ab17a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 16, 2023

Node: E2E Test Results

    1 files      1 suites   22m 18s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 5613408.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 16, 2023

Node: Integration Test Results

279 tests   279 ✔️  28m 14s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 5613408.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 16, 2023

Node: HAPI Test Results

1 245 tests   910 ✔️  1h 33m 49s ⏱️
   166 suites  335 💤
   166 files        0

Results for commit 5613408.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that if we just add PAYER_ACCOUNT_DELETED here a 120s run of this @HapiTest was stable (with no other changes needed anywhere).

I would prefer this instead of introducing extra cases to the node software here. 😞

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
@iwsimon
Copy link
Contributor Author

iwsimon commented Nov 17, 2023

I confirmed that if we just add PAYER_ACCOUNT_DELETED here a 120s run of this @HapiTest was stable (with no other changes needed anywhere).

I would prefer this instead of introducing extra cases to the node software here. 😞

It makes sense to modify the test-clients code to include more precheck scenarios than node code to check where the code is executed throw different PreCheckException. With this change though, we still had FAIL_INVALID errors. It's fixed by the change in HandleWorkflow.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @iwsimon !

@iwsimon iwsimon merged commit c812f68 into develop Nov 17, 2023
14 of 15 checks passed
@iwsimon iwsimon deleted the 9505-HollowAccountCompletionFuzzing branch November 17, 2023 17:43
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix HollowAccountCompletionFuzzing
2 participants