New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed HollowAccountCompletionFuzzing #9947
Conversation
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that if we just add PAYER_ACCOUNT_DELETED
here a 120s run of this @HapiTest
was stable (with no other changes needed anywhere).
I would prefer this instead of introducing extra cases to the node software here. 😞
This reverts commit c848733.
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
It makes sense to modify the test-clients code to include more precheck scenarios than node code to check where the code is executed throw different PreCheckException. With this change though, we still had FAIL_INVALID errors. It's fixed by the change in HandleWorkflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @iwsimon !
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Description:
Related issue(s):
Fixes #9505
Notes for reviewer:
Checklist