documentation & module tests for config #9953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Node: E2E Test Results 1 files ± 0 1 suites ±0 20m 11s ⏱️ + 20m 11s Results for commit 8bfa583. ± Comparison against base commit fe5882f. This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
timo0
previously approved these changes
Nov 20, 2023
platform-sdk/swirlds-config-api/src/main/java/com/swirlds/config/api/package-info.java
Show resolved
Hide resolved
…ig/api/package-info.java Co-authored-by: Timo Brandstätter <timo@swirldslabs.com> Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9953 +/- ##
=============================================
- Coverage 65.45% 65.44% -0.01%
+ Complexity 30210 30209 -1
=============================================
Files 3315 3315
Lines 126637 126637
Branches 13161 13161
=============================================
- Hits 82885 82883 -2
- Misses 40558 40560 +2
Partials 3194 3194 ☔ View full report in Codecov by Sentry. |
lpetrovic05
reviewed
Nov 22, 2023
...xtensions/src/test/java/com/swirlds/config/extensions/test/PropertyFileConfigSourceTest.java
Show resolved
Hide resolved
lpetrovic05
approved these changes
Nov 22, 2023
timo0
approved these changes
Nov 22, 2023
jeromy-cannon
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9952