Fix whitelistpositivecase test in LeakyContractTestsSuite
#9955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermittedDelegateCallers and use it to check for qualified delegate callers. Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Node: E2E Test Results 1 files ± 0 1 suites ±0 21m 50s ⏱️ + 21m 50s Results for commit b916917. ± Comparison against base commit edc657a. This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
# Conflicts: # hedera-node/hedera-config/src/main/java/module-info.java
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
MrValioBg
requested review from
tomzhenghedera,
leninmehedy,
netopyr and
david-bakin-sl
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #9955 +/- ##
=============================================
+ Coverage 65.27% 65.28% +0.01%
- Complexity 30202 30211 +9
=============================================
Files 3329 3329
Lines 126937 126940 +3
Branches 13198 13200 +2
=============================================
+ Hits 82853 82872 +19
+ Misses 40868 40852 -16
Partials 3216 3216 ☔ View full report in Codecov by Sentry. |
netopyr
reviewed
Nov 21, 2023
...vice-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/utils/FrameUtils.java
Outdated
Show resolved
Hide resolved
tinker-michaelj
requested changes
Nov 22, 2023
…et<Long> for permittedDelegateCallers and converting it in the check in FrameUtils.java Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
tinker-michaelj
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix
whitelistpositivecasetest in LeakyContractTestsSuite.Add support for besu Address in hedera-config in order to enable permittedDelegateCallers and add check in FrameUtils for qualified delegate callers.
Related issue(s):
Fixes #9407
Checklist