Move Hip17UnhappyAccountsSuite tests for expiry to new suite
#9956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95
changed the title
Hip17UnhappyAccountsSuite tests for expiry to new suite
netopyr
approved these changes
Nov 17, 2023
tinker-michaelj
approved these changes
Nov 17, 2023
nickpoorman
pushed a commit
that referenced
this pull request
Nov 22, 2023
This PR moves two tests from `Hip17UnhappyAccountsSuite` to a new suite, because they tests functionality around expiry, which won't be implemented soon. Discussion here: #8556 Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR moves two tests from
Hip17UnhappyAccountsSuiteto a new suite, because they tests functionality around expiry, which won't be implemented soon.Discussion here: #8556
Related issue(s):
Fixes #8556
Notes for reviewer:
Checklist