Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

09971 simple timer api #9972

Merged
merged 6 commits into from Nov 21, 2023
Merged

09971 simple timer api #9972

merged 6 commits into from Nov 21, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #9971

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Copy link

github-actions bot commented Nov 17, 2023

Node: Unit Test Results

    2 283 files  ±0      2 283 suites  ±0   1h 27m 17s ⏱️ + 12m 50s
118 359 tests ±0  118 325 ✔️ ±0  34 💤 ±0  0 ±0 
126 677 runs  ±0  126 643 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit d2d37f3. ± Comparison against base commit d68df70.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 17, 2023

Node: E2E Test Results

    1 files      1 suites   21m 59s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit d2d37f3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 17, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 28s ⏱️ -1s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit d2d37f3. ± Comparison against base commit d68df70.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 17, 2023

Node: HAPI Test Results

1 245 tests   913 ✔️  1h 27m 49s ⏱️
   166 suites  332 💤
   166 files        0

Results for commit d2d37f3.

♻️ This comment has been updated with latest results.

lpetrovic05
lpetrovic05 previously approved these changes Nov 20, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@d68df70). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #9972   +/-   ##
==========================================
  Coverage           ?   65.38%           
  Complexity         ?    30184           
==========================================
  Files              ?     3320           
  Lines              ?   126632           
  Branches           ?    13157           
==========================================
  Hits               ?    82796           
  Misses             ?    40643           
  Partials           ?     3193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alittley
alittley previously approved these changes Nov 21, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley merged commit e8c2c5b into develop Nov 21, 2023
16 of 17 checks passed
@cody-littley cody-littley deleted the 09971-simple-timer-api branch November 21, 2023 16:23
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiring framework: simpler API for timer input
3 participants