Fix inital set of ScheduleExecutionSpecs HapiTest methods. #9979

jsync-swirlds · 2023-11-17T22:58:49Z

Modified the workflow to skip the correct configured number of nanoseconds before the first child transaction consensus time.
Marked all tests in ScheduleExecutionSpecs with @HapiTest or @todo('issue#') and file issues for groups with similar failures
Small code cleanups to move shared methods to ScheduleUtils instead of scattered across various test suites.

github-actions · 2023-11-17T23:46:24Z

Node: Unit Test Results

    2 286 files ±0     2 286 suites ±0 48m 11s ⏱️ +20s
118 389 tests ±0 118 355 ✔️ ±0 34 💤 ±0 0 ❌ ±0
126 761 runs ±0 126 727 ✔️ ±0 34 💤 ±0 0 ❌ ±0

Results for commit e712085. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-18T00:48:22Z

Node: E2E Test Results

    1 files ±    0     1 suites ±0 22m 48s ⏱️ + 22m 48s
310 tests +309 310 ✔️ +310 0 💤 ±0 0 ❌ - 1
332 runs +331 332 ✔️ +332 0 💤 ±0 0 ❌ - 1

Results for commit e712085. ± Comparison against base commit 0203ede.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.

EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

github-actions · 2023-11-18T00:54:16Z

Node: Integration Test Results

279 tests ±0 279 ✔️ ±0 28m 35s ⏱️ +41s
    5 suites ±0     0 💤 ±0
    5 files ±0     0 ❌ ±0

Results for commit e712085. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-18T01:57:33Z

Node: HAPI Test Results

1 246 tests 989 ✔️ 1h 37m 44s ⏱️
  166 suites 257 💤
  166 files     0 ❌

Results for commit 050d79b.

♻️ This comment has been updated with latest results.

codecov · 2023-11-21T16:37:58Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0203ede) 63.13% compared to head (e712085) 63.12%.

Files	Patch %	Lines
...app/workflows/handle/record/RecordListBuilder.java	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #9979      +/-   ##
=============================================
- Coverage      63.13%   63.12%   -0.01%     
+ Complexity     30700    30696       -4     
=============================================
  Files           3327     3327              
  Lines         133875   133876       +1     
  Branches       13875    13876       +1     
=============================================
- Hits           84523    84514       -9     
- Misses         46022    46024       +2     
- Partials        3330     3338       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.../hedera-app/src/main/java/com/hedera/node/app/workflows/handle/record/RecordListBuilder.java

github-actions · 2023-11-22T19:04:28Z

Node: HAPI Test (Time Consuming) Results

21 tests ±0   9 ✔️ ±0 24m 46s ⏱️ - 1m 3s
  2 suites ±0 12 💤 ±0
  2 files ±0   0 ❌ ±0

Results for commit e712085. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-22T19:17:28Z

Node: HAPI Test (Crypto) Results

211 tests ±0 201 ✔️ ±0 17m 11s ⏱️ - 3m 21s
  22 suites ±0   10 💤 ±0
  22 files ±0     0 ❌ ±0

Results for commit e712085. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-22T19:18:47Z

Node: HAPI Test (Token) Results

190 tests ±0 188 ✔️ ±0 19m 47s ⏱️ -10s
  13 suites ±0     2 💤 ±0
  13 files ±0     0 ❌ ±0

Results for commit e712085. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-22T19:22:46Z

Node: HAPI Test (Misc) Results

418 tests ±0 307 ✔️ +21 23m 12s ⏱️ - 1m 28s
  73 suites ±0 111 💤 - 21
  73 files ±0     0 ❌ ±  0

Results for commit e712085. ± Comparison against base commit 0203ede.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.

com.hedera.services.bdd.suites.schedule.ScheduleExecutionSpecs ‑ aSuiteSetup
com.hedera.services.bdd.suites.schedule.ScheduleExecutionSpecs ‑ zSuiteCleanup
com.hedera.services.bdd.suites.schedule.ScheduleSignSpecs ‑ bumpThirdNestedThresholdSigningReq

com.hedera.services.bdd.suites.schedule.ScheduleExecutionSpecs ‑ scheduledSystemDeleteUnauthorizedPayerFails
com.hedera.services.bdd.suites.schedule.ScheduleExecutionSpecs ‑ suiteCleanup
com.hedera.services.bdd.suites.schedule.ScheduleExecutionSpecs ‑ suiteSetup

This pull request removes 3 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.

com.hedera.services.bdd.suites.schedule.ScheduleExecutionSpecs ‑ aSuiteSetup
com.hedera.services.bdd.suites.schedule.ScheduleExecutionSpecs ‑ zSuiteCleanup
com.hedera.services.bdd.suites.schedule.ScheduleSignSpecs ‑ bumpThirdNestedThresholdSigningReq

com.hedera.services.bdd.suites.schedule.ScheduleExecutionSpecs ‑ scheduledSystemDeleteUnauthorizedPayerFails
com.hedera.services.bdd.suites.schedule.ScheduleExecutionSpecs ‑ suiteCleanup
com.hedera.services.bdd.suites.schedule.ScheduleExecutionSpecs ‑ suiteSetup

♻️ This comment has been updated with latest results.

github-actions · 2023-11-22T19:39:00Z

Node: HAPI Test (Smart Contract) Results

411 tests ±0 318 ✔️ ±0 45m 28s ⏱️ + 2m 27s
  56 suites ±0   93 💤 ±0
  56 files ±0     0 ❌ ±0

Results for commit e712085. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

kimbor

lgtm!

jsync-swirlds · 2023-11-27T23:08:57Z

lgtm!

Had to fix a unit test. Please re-review.

tinker-michaelj

LGTM!

* Modifie the workflow to skip the correct configured number of nanoseconds before the scheduled child transaction consensus time. * Modified unit tests to match * Marked all tests in ScheduleExecutionSpecs with `@HapiTest` or `@todo('issue#')` and file issues for groups with similar failures * Small code cleanups to move shared methods to ScheduleUtils instead of scattered across various test suites. Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>

Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>

jsync-swirlds self-assigned this Nov 17, 2023

jsync-swirlds force-pushed the 09048-fix-schedule-execution-specs branch from f384e9b to ae07b91 Compare November 17, 2023 23:22

jsync-swirlds force-pushed the 09048-fix-schedule-execution-specs branch 2 times, most recently from cb04359 to e7c20f6 Compare November 18, 2023 00:19

jsync-swirlds force-pushed the 09048-fix-schedule-execution-specs branch 2 times, most recently from 1e43f02 to 2b3b847 Compare November 20, 2023 18:21

jsync-swirlds marked this pull request as ready for review November 20, 2023 19:11

jsync-swirlds requested review from a team as code owners November 20, 2023 19:11

jsync-swirlds requested review from Neeharika-Sompalli, mhess-swl, isavov and leninmehedy November 20, 2023 19:11

jsync-swirlds force-pushed the 09048-fix-schedule-execution-specs branch from 2b3b847 to 723b36a Compare November 21, 2023 16:09

jsync-swirlds force-pushed the 09048-fix-schedule-execution-specs branch from 723b36a to 050d79b Compare November 21, 2023 18:36

jsync-swirlds requested a review from kimbor November 22, 2023 16:03

netopyr reviewed Nov 22, 2023

View reviewed changes

.../hedera-app/src/main/java/com/hedera/node/app/workflows/handle/record/RecordListBuilder.java Outdated Show resolved Hide resolved

.../hedera-app/src/main/java/com/hedera/node/app/workflows/handle/record/RecordListBuilder.java Outdated Show resolved Hide resolved

jsync-swirlds force-pushed the 09048-fix-schedule-execution-specs branch from 050d79b to 563504b Compare November 22, 2023 18:51

jsync-swirlds force-pushed the 09048-fix-schedule-execution-specs branch 5 times, most recently from 1eb1244 to 8efbe90 Compare November 27, 2023 21:24

kimbor previously approved these changes Nov 27, 2023

View reviewed changes

jsync-swirlds dismissed kimbor’s stale review via 31bd887 November 27, 2023 23:08

jsync-swirlds force-pushed the 09048-fix-schedule-execution-specs branch from 8efbe90 to 31bd887 Compare November 27, 2023 23:08

tinker-michaelj approved these changes Nov 28, 2023

View reviewed changes

jsync-swirlds force-pushed the 09048-fix-schedule-execution-specs branch from 31bd887 to 592ebf7 Compare November 28, 2023 00:51

kimbor approved these changes Nov 28, 2023

View reviewed changes

jsync-swirlds force-pushed the 09048-fix-schedule-execution-specs branch from 592ebf7 to e712085 Compare November 28, 2023 16:33

jsync-swirlds merged commit 3d2e842 into develop Nov 28, 2023
24 of 25 checks passed

jsync-swirlds deleted the 09048-fix-schedule-execution-specs branch November 28, 2023 18:58

agadzhalov pushed a commit that referenced this pull request Dec 1, 2023

Fix inital set of ScheduleExecutionSpecs HapiTest methods. (#9979)

e0f87b2

Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>

agadzhalov pushed a commit that referenced this pull request Dec 1, 2023

Fix inital set of ScheduleExecutionSpecs HapiTest methods. (#9979)

4535c04

Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix inital set of ScheduleExecutionSpecs HapiTest methods. #9979

Fix inital set of ScheduleExecutionSpecs HapiTest methods. #9979

jsync-swirlds commented Nov 17, 2023 •

edited

github-actions bot commented Nov 17, 2023 •

edited

github-actions bot commented Nov 18, 2023 •

edited

github-actions bot commented Nov 18, 2023 •

edited

github-actions bot commented Nov 18, 2023 •

edited

codecov bot commented Nov 21, 2023 •

edited

github-actions bot commented Nov 22, 2023 •

edited

github-actions bot commented Nov 22, 2023 •

edited

github-actions bot commented Nov 22, 2023 •

edited

github-actions bot commented Nov 22, 2023 •

edited

github-actions bot commented Nov 22, 2023 •

edited

kimbor left a comment

jsync-swirlds commented Nov 27, 2023

tinker-michaelj left a comment

Fix inital set of ScheduleExecutionSpecs HapiTest methods. #9979

Fix inital set of ScheduleExecutionSpecs HapiTest methods. #9979

Conversation

jsync-swirlds commented Nov 17, 2023 • edited

github-actions bot commented Nov 17, 2023 • edited

Node: Unit Test Results

github-actions bot commented Nov 18, 2023 • edited

Node: E2E Test Results

github-actions bot commented Nov 18, 2023 • edited

Node: Integration Test Results

github-actions bot commented Nov 18, 2023 • edited

Node: HAPI Test Results

codecov bot commented Nov 21, 2023 • edited

Codecov Report

github-actions bot commented Nov 22, 2023 • edited

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Nov 22, 2023 • edited

Node: HAPI Test (Crypto) Results

github-actions bot commented Nov 22, 2023 • edited

Node: HAPI Test (Token) Results

github-actions bot commented Nov 22, 2023 • edited

Node: HAPI Test (Misc) Results

github-actions bot commented Nov 22, 2023 • edited

Node: HAPI Test (Smart Contract) Results

kimbor left a comment

Choose a reason for hiding this comment

jsync-swirlds commented Nov 27, 2023

tinker-michaelj left a comment

Choose a reason for hiding this comment

jsync-swirlds commented Nov 17, 2023 •

edited

github-actions bot commented Nov 17, 2023 •

edited

github-actions bot commented Nov 18, 2023 •

edited

github-actions bot commented Nov 18, 2023 •

edited

github-actions bot commented Nov 18, 2023 •

edited

codecov bot commented Nov 21, 2023 •

edited

github-actions bot commented Nov 22, 2023 •

edited

github-actions bot commented Nov 22, 2023 •

edited

github-actions bot commented Nov 22, 2023 •

edited

github-actions bot commented Nov 22, 2023 •

edited

github-actions bot commented Nov 22, 2023 •

edited