Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9990 Move rest of config related classes from swirlds-common to conf… #9991

Merged
merged 10 commits into from Nov 29, 2023
Merged

#9990 Move rest of config related classes from swirlds-common to conf… #9991

merged 10 commits into from Nov 29, 2023

Conversation

timo0
Copy link
Member

@timo0 timo0 commented Nov 20, 2023

Fix #9990

@timo0
#9990 Move rest of config related classes from swirlds-common to conf…
56e2bfd 
…ig-extensions

Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 added this to the v0.45 milestone Nov 20, 2023
@timo0 timo0 self-assigned this Nov 20, 2023
@timo0 timo0 requested review from a team as code owners November 20, 2023 10:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited

Node: Unit Test Results

    2 286 files  ±0      2 286 suites  ±0   43m 1s ⏱️ - 4m 50s
118 389 tests ±0  118 355 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
126 761 runs  ±0  126 727 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit 909119a. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 27s ⏱️ + 22m 27s
310 tests +309  310 ✔️ +310  0 💤 ±0  0 ❌  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0 ❌  - 1 

Results for commit 909119a. ± Comparison against base commit 0203ede.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   27m 47s ⏱️ -7s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 909119a. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited

Node: HAPI Test Results

1 245 tests  ±0   913 ✔️ ±0   1h 27m 11s ⏱️ -6s
   166 suites ±0   332 💤 ±0 
   166 files   ±0       0 ❌ ±0 

Results for commit 2ed546a. ± Comparison against base commit d68df70.

♻️ This comment has been updated with latest results.

lpetrovic05
lpetrovic05 previously approved these changes Nov 21, 2023
View reviewed changes
netopyr
netopyr previously approved these changes Nov 21, 2023
View reviewed changes
@timo0
Fix star import
ab749e1 
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 dismissed stale reviews from netopyr and lpetrovic05 via ab749e1 November 21, 2023 11:02
hendrikebbers
hendrikebbers previously approved these changes Nov 21, 2023
View reviewed changes
@timo0
Fix merge
987c415 
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
lpetrovic05
lpetrovic05 previously approved these changes Nov 28, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   21m 57s ⏱️ + 2m 0s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ❌ ±0 

Results for commit 909119a. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   20m 47s ⏱️ +15s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit 909119a. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited

Node: HAPI Test (Misc) Results

418 tests  ±0   286 ✔️ ±0   21m 20s ⏱️ - 3m 20s
  73 suites ±0   132 💤 ±0 
  73 files   ±0       0 ❌ ±0 

Results for commit 909119a. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

netopyr
netopyr previously approved these changes Nov 28, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   26m 14s ⏱️ +25s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 909119a. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited

Node: HAPI Test (Smart Contract) Results

411 tests  ±0   318 ✔️ ±0   49m 55s ⏱️ + 6m 54s
  56 suites ±0     93 💤 ±0 
  56 files   ±0       0 ❌ ±0 

Results for commit 909119a. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

@timo0
Remove module-info.java
acc1cc6 
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 dismissed stale reviews from netopyr and lpetrovic05 via acc1cc6 November 28, 2023 13:29
povolev15
povolev15 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timo0 timo0 merged commit 5388c14 into develop Nov 29, 2023
24 of 25 checks passed
@timo0 timo0 deleted the 09990-d-rest-config-extensions branch November 29, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imalygin imalygin imalygin approved these changes

@nathanklick nathanklick nathanklick approved these changes

@hendrikebbers hendrikebbers hendrikebbers approved these changes

@povolev15 povolev15 povolev15 approved these changes

@lpetrovic05 lpetrovic05 lpetrovic05 approved these changes

@JeffreyDallas JeffreyDallas Awaiting requested review from JeffreyDallas JeffreyDallas is a code owner automatically assigned from hashgraph/release-engineering

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

@poulok poulok Awaiting requested review from poulok poulok is a code owner automatically assigned from hashgraph/platform-hashgraph

@OlegMazurov OlegMazurov Awaiting requested review from OlegMazurov OlegMazurov is a code owner automatically assigned from hashgraph/platform-architects

@Neeharika-Sompalli Neeharika-Sompalli Awaiting requested review from Neeharika-Sompalli Neeharika-Sompalli is a code owner automatically assigned from hashgraph/hedera-base

@kimbor kimbor Awaiting requested review from kimbor kimbor is a code owner automatically assigned from hashgraph/hedera-services

@artemananiev artemananiev Awaiting requested review from artemananiev

@qnswirlds qnswirlds Awaiting requested review from qnswirlds

@netopyr netopyr Awaiting requested review from netopyr

Assignees

@timo0 timo0

Labels
None yet
Projects
None yet
Milestone
v0.45
Development

Successfully merging this pull request may close these issues.

Move rest of config related classes from swirlds-common to config-extensions
10 participants
@timo0 @imalygin @netopyr @nathanklick @hendrikebbers @povolev15 @lpetrovic05 @artemananiev @qnswirlds @JeffreyDallas