feat: schedule create throttling #9994

MiroslavGatsanoga · 2023-11-20T11:03:07Z

Description:

Update mod implementation of the throttle facility to handle the case of ScheduleCreate transactions and also accumulate for the scheduled transaction within that ScheduleCreate.

Related issue(s):

Fixes #9798

Notes for reviewer:

The PR adds the ScheduleCreate & ScheduleSign related implementation in the existing throttle facility. What is still not implemented (to be addressed in the future):

The schedule type throttling corresponding to this one from mono that is used in ScheduleProcessing.java.

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

github-actions · 2023-11-20T11:27:27Z

Node: Unit Test Results

    2 284 files +  1     2 284 suites +1 46m 56s ⏱️ -26s
118 382 tests +17 118 348 ✔️ +17 34 💤 ±0 0 ❌ ±0
126 756 runs +73 126 722 ✔️ +73 34 💤 ±0 0 ❌ ±0

Results for commit 6facfa6. ± Comparison against base commit fd86222.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-20T11:31:39Z

Node: E2E Test Results

    1 files     1 suites 22m 27s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
332 runs 332 ✔️ 0 💤 0 ❌

Results for commit 6facfa6.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-20T11:39:05Z

Node: Integration Test Results

279 tests 279 ✔️ 28m 14s ⏱️
    5 suites     0 💤
    5 files     0 ❌

Results for commit 6facfa6.

♻️ This comment has been updated with latest results.

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

MiroslavGatsanoga · 2023-11-20T15:50:03Z

@jsync-swirlds regarding the Notes for reviewer section: should we create issues for those two items now or they are not planned to be part of the initial modularization release? cc @netopyr

github-actions · 2023-11-20T17:29:33Z

Node: HAPI Test Results

1 245 tests ±0 968 ✔️ ±0 1h 36m 6s ⏱️ + 4m 10s
  166 suites ±0 277 💤 ±0
  166 files ±0     0 ❌ ±0

Results for commit 2d5ddde. ± Comparison against base commit 1783f9d.

♻️ This comment has been updated with latest results.

jsync-swirlds · 2023-11-20T18:25:56Z

@jsync-swirlds regarding the Notes for reviewer section: should we create issues for those two items now or they are not planned to be part of the initial modularization release? cc @netopyr

The ScheduleSign throttling needs to be done to maintain network limits.
I'm not sure about the "timed" schedule throttling; that might be worth bringing up in the modularization call.

jsync-swirlds

A few clarifying questions.

hedera-node/hedera-app/build.gradle.kts

hedera-node/hedera-app/src/main/java/com/hedera/node/app/throttle/ThrottleAccumulator.java

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

codecov · 2023-11-21T10:09:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@fd86222). Click here to learn what that means.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #9994   +/-   ##
==========================================
  Coverage           ?   65.36%           
  Complexity         ?    30268           
==========================================
  Files              ?     3329           
  Lines              ?   127034           
  Branches           ?    13221           
==========================================
  Hits               ?    83039           
  Misses             ?    40755           
  Partials           ?     3240

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MiroslavGatsanoga · 2023-11-21T11:15:49Z

The ScheduleSign throttling needs to be done to maintain network limits.

Ok, I will add that to this PR as well then.

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

hedera-node/hedera-app/src/main/java/com/hedera/node/app/throttle/ThrottleAccumulator.java

...ce-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtility.java

hedera-node/hedera-app/src/main/java/com/hedera/node/app/throttle/ThrottleAccumulator.java

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

github-actions · 2023-11-23T14:06:41Z

Node: HAPI Test (Time Consuming) Results

21 tests   4 ✔️ 6m 13s ⏱️
  2 suites 17 💤
  2 files   0 ❌

Results for commit 6facfa6.

github-actions · 2023-11-23T14:18:26Z

Node: HAPI Test (Crypto) Results

211 tests 201 ✔️ 19m 48s ⏱️
  22 suites   10 💤
  22 files     0 ❌

Results for commit 6facfa6.

github-actions · 2023-11-23T14:21:03Z

Node: HAPI Test (Token) Results

190 tests 188 ✔️ 21m 32s ⏱️
  13 suites     2 💤
  13 files     0 ❌

Results for commit 6facfa6.

github-actions · 2023-11-23T14:21:58Z

Node: HAPI Test (Misc) Results

418 tests 273 ✔️ 23m 6s ⏱️
  73 suites 145 💤
  73 files     0 ❌

Results for commit 6facfa6.

github-actions · 2023-11-23T14:41:55Z

Node: HAPI Test (Smart Contract) Results

410 tests 318 ✔️ 42m 35s ⏱️
  56 suites   92 💤
  56 files     0 ❌

Results for commit 6facfa6.

tinker-michaelj

All makes sense to me, tyvm @MiroslavGatsanoga !

MiroslavGatsanoga added 2 commits November 17, 2023 21:20

Initial implementation

9c9a933

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

Add unit tests

1274f3b

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

MiroslavGatsanoga added 4 commits November 20, 2023 14:56

fix: spotless check

0605df9

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

feat: add resetUsage() method

e202b4d

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

test: add more unit tests

54c50ce

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

Merge branch 'develop' into 09798-schedule-create-throttle

3a235c4

MiroslavGatsanoga marked this pull request as ready for review November 20, 2023 15:49

MiroslavGatsanoga requested review from a team as code owners November 20, 2023 15:49

MiroslavGatsanoga requested review from deepak-swirlds, nathanklick, netopyr and jsync-swirlds November 20, 2023 15:49

jsync-swirlds reviewed Nov 20, 2023

View reviewed changes

MiroslavGatsanoga added 3 commits November 21, 2023 11:08

fix: make parameter final

2132ca5

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

fix: stop using var for primitives

e88caed

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

chore: add comment

3ac4213

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

MiroslavGatsanoga added 3 commits November 22, 2023 14:27

feat: implement ScheduleSign throttling

a9e71bf

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

fix: rename isChild to isScheduled

afe41a1

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

fix: refactor based on longTermEnabled + additional logging

f6e0b2d

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

MiroslavGatsanoga added 2 commits November 22, 2023 15:33

fix: remove usage of junitpioneer

203bba6

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

Merge branch 'develop' into 09798-schedule-create-throttle

2d5ddde

MiroslavGatsanoga requested a review from jsync-swirlds November 22, 2023 13:40

jsync-swirlds reviewed Nov 22, 2023

View reviewed changes

hedera-node/hedera-app/src/main/java/com/hedera/node/app/throttle/ThrottleAccumulator.java Outdated Show resolved Hide resolved

jsync-swirlds reviewed Nov 22, 2023

View reviewed changes

...ce-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtility.java Show resolved Hide resolved

jsync-swirlds reviewed Nov 22, 2023

View reviewed changes

hedera-node/hedera-app/src/main/java/com/hedera/node/app/throttle/ThrottleAccumulator.java Show resolved Hide resolved

MiroslavGatsanoga added 2 commits November 23, 2023 15:23

fix: log warnings only when long term scheduling is enabled

1e5c175

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

Merge branch 'develop' into 09798-schedule-create-throttle

6facfa6

MiroslavGatsanoga requested a review from jsync-swirlds November 23, 2023 13:52

jsync-swirlds approved these changes Nov 27, 2023

View reviewed changes

povolev15 self-requested a review November 27, 2023 19:58

tinker-michaelj approved these changes Nov 27, 2023

View reviewed changes

jeromy-cannon approved these changes Nov 27, 2023

View reviewed changes

povolev15 merged commit e5a516c into develop Nov 27, 2023
24 of 25 checks passed

povolev15 deleted the 09798-schedule-create-throttle branch November 27, 2023 20:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: schedule create throttling #9994

feat: schedule create throttling #9994

MiroslavGatsanoga commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

MiroslavGatsanoga commented Nov 20, 2023

github-actions bot commented Nov 20, 2023 •

edited

jsync-swirlds commented Nov 20, 2023

jsync-swirlds left a comment

codecov bot commented Nov 21, 2023 •

edited

MiroslavGatsanoga commented Nov 21, 2023

github-actions bot commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

tinker-michaelj left a comment

feat: schedule create throttling #9994

feat: schedule create throttling #9994

Conversation

MiroslavGatsanoga commented Nov 20, 2023 • edited

github-actions bot commented Nov 20, 2023 • edited

Node: Unit Test Results

github-actions bot commented Nov 20, 2023 • edited

Node: E2E Test Results

github-actions bot commented Nov 20, 2023 • edited

Node: Integration Test Results

MiroslavGatsanoga commented Nov 20, 2023

github-actions bot commented Nov 20, 2023 • edited

Node: HAPI Test Results

jsync-swirlds commented Nov 20, 2023

jsync-swirlds left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 21, 2023 • edited

Codecov Report

MiroslavGatsanoga commented Nov 21, 2023

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Crypto) Results

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Token) Results

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Misc) Results

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Smart Contract) Results

tinker-michaelj left a comment

Choose a reason for hiding this comment

MiroslavGatsanoga commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

codecov bot commented Nov 21, 2023 •

edited