Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests from ERCPrecompileSuite #9995

Merged
merged 9 commits into from Nov 29, 2023

Conversation

mustafauzunn
Copy link
Collaborator

@mustafauzunn mustafauzunn commented Nov 20, 2023

Description:

Enable tests from ERCPrecompileSuite

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn added the Limechain Work planned for the LimeChain team label Nov 20, 2023
@mustafauzunn mustafauzunn self-assigned this Nov 20, 2023
@mustafauzunn mustafauzunn requested review from a team as code owners November 20, 2023 11:27
Copy link

github-actions bot commented Nov 20, 2023

Node: Unit Test Results

    2 286 files  +  2      2 286 suites  +2   49m 28s ⏱️ - 2m 17s
118 389 tests +22  118 355 ✔️ +22  34 💤 ±0  0 ±0 
126 761 runs  +78  126 727 ✔️ +78  34 💤 ±0  0 ±0 

Results for commit 4b7f786. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 20, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 17s ⏱️ + 22m 17s
310 tests +309  310 ✔️ +310  0 💤 ±0  0  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0  - 1 

Results for commit 4b7f786. ± Comparison against base commit b9add91.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 20, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 23s ⏱️ +5s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 4b7f786. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

Copy link

Node: HAPI Test Results

1 245 tests  ±0   911 ✔️ +1   1h 30m 29s ⏱️ - 9m 26s
   166 suites ±0   333 💤  - 2 
   166 files   ±0       1 +1 

For more details on these failures, see this check.

Results for commit deeab35. ± Comparison against base commit 6582f75.

@mustafauzunn mustafauzunn marked this pull request as draft November 20, 2023 13:34
@mustafauzunn mustafauzunn removed the request for review from tinker-michaelj November 20, 2023 13:34
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Copy link

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   26m 18s ⏱️ +12s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 4b7f786. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   20m 30s ⏱️ + 2m 37s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 4b7f786. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   17m 41s ⏱️ -33s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 4b7f786. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@b9add91). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #9995   +/-   ##
==========================================
  Coverage           ?   63.13%           
  Complexity         ?    30698           
==========================================
  Files              ?     3327           
  Lines              ?   133890           
  Branches           ?    13876           
==========================================
  Hits               ?    84533           
  Misses             ?    46020           
  Partials           ?     3337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Misc) Results

418 tests  ±0   286 ✔️ +13   23m 45s ⏱️ + 1m 57s
  73 suites ±0   132 💤  - 13 
  73 files   ±0       0 ±  0 

Results for commit 4b7f786. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Smart Contract) Results

411 tests  +1   321 ✔️ +3   42m 13s ⏱️ + 3m 8s
  56 suites ±0     90 💤  - 2 
  56 files   ±0       0 ±0 

Results for commit 4b7f786. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn marked this pull request as ready for review November 29, 2023 12:54
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @mustafauzunn !

@tinker-michaelj tinker-michaelj merged commit 17a7b93 into develop Nov 29, 2023
24 of 25 checks passed
@tinker-michaelj tinker-michaelj deleted the 09736-erc-precompile-suite-3 branch November 29, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants