fix: tests from LeakyContractTestsSuite #9997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration when externalizing nonces. Add additional check for exceeded associations. Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Node: E2E Test Results 1 files ± 0 1 suites ±0 21m 55s ⏱️ + 21m 55s Results for commit fcabed2. ± Comparison against base commit edc657a. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #9997 +/- ##
=============================================
- Coverage 65.27% 63.11% -2.16%
- Complexity 30202 30723 +521
=============================================
Files 3329 3335 +6
Lines 126937 134142 +7205
Branches 13198 13915 +717
=============================================
+ Hits 82853 84659 +1806
- Misses 40868 46139 +5271
- Partials 3216 3344 +128 ☔ View full report in Codecov by Sentry. |
tinker-michaelj
requested changes
Nov 22, 2023
There was a problem hiding this comment.
The nonceInfo feature flag is recent enough, and your implementation is very clean, so keeping that in mod-service seems totally reasonable.
But the token associations limit feature flag we will never re-enable. So continuing to enforce it and adding noticeable code to do so doesn't really make sense. 😞
I think we should remove those changes and replace existing spec autoAssociationSlotsAppearsInInfo() with,
@HapiTest
private HapiSpec autoAssociationSlotsAppearsInInfo() {
final int maxAutoAssociations = 100;
final String CONTRACT = "Multipurpose";
return propertyPreservingHapiSpec("autoAssociationSlotsAppearsInInfo")
.preserving(CONTRACT_ALLOW_ASSOCIATIONS_PROPERTY)
.given(overriding(
CONTRACT_ALLOW_ASSOCIATIONS_PROPERTY,
"true"))
.when()
.then(
newKeyNamed(ADMIN_KEY),
uploadInitCode(CONTRACT),
contractCreate(CONTRACT).adminKey(ADMIN_KEY).maxAutomaticTokenAssociations(maxAutoAssociations),
getContractInfo(CONTRACT)
.has(ContractInfoAsserts.contractWith().maxAutoAssociations(maxAutoAssociations))
.logged());
}
…be supported. Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
…no longer support feature flag for limit Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Node: HAPI Test (Misc) Results419 tests +1 316 ✔️ +43 27m 5s ⏱️ + 6m 39s Results for commit fcabed2. ± Comparison against base commit edc657a. This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.This pull request removes 3 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results405 tests - 5 325 ✔️ +13 45m 10s ⏱️ + 4m 45s Results for commit fcabed2. ± Comparison against base commit edc657a. This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both.This pull request removes 6 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Understood! I Implemented the changes :) |
mustafauzunn
requested review from
tinker-michaelj
and removed request for
tinker-michaelj
mustafauzunn
changed the title
...mpl/src/main/java/com/hedera/node/app/service/contract/impl/state/RootProxyWorldUpdater.java
Outdated
Show resolved
Hide resolved
tinker-michaelj
previously approved these changes
Dec 1, 2023
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
tinker-michaelj
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests from LeakyContractTestsSuite.
Description:
In this PR we add check for noncesExternalizationEnabled flag in
RootProxyWorldUpdaterin order to fixcontractCreateNoncesExternalizationHappyPath&shouldReturnNullWhenContractsNoncesExternalizationFlagIsDisabledtests.Since limit feature flag won't be supported anymore we just fix the HAPI test
autoAssociationSlotsAppearsInInfoRelated issue(s):
Fixes #9402
#9408
Checklist