Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default expiry modifier #4

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Default expiry modifier #4

merged 3 commits into from
Jul 12, 2022

Conversation

stoqnkpL
Copy link
Contributor

Renames helper functions like suggested here
Adds nonEmptyExpiry modifier to mirror SDKs behavior
Adds createTokenWithDefaultExpiryAndEmptyKeys to TokenCreateContract examples

Signed-off-by: Stoyan Panayotov stoyan.panayotov@limechain.tech

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@stoqnkpL
Rename helper functions
b1a7f33 
Add nonEmptyExpiry modifier to mirror sdks behaviour
Add createTokenWithDefaultExpiryAndEmptyKeys to TokenCreateContract examples

Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>
@stoqnkpL
Adds SafeHTS library
100d0bc 
Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>
@Kalina-Todorova Kalina-Todorova mentioned this pull request Jun 17, 2022
Closed
@Nana-EC Nana-EC requested a review from shemnon June 27, 2022 14:43
@Nana-EC Nana-EC added the HTS Hedera Token Service related label Jun 27, 2022
@stoqnkpL
Removed the SafeHTS precompiles library - will be added in a differen…
9a4241b 
…t PR

Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>
Nana-EC
Nana-EC approved these changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.
Presuming this only impacts test code on the services side

shemnon
shemnon approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also becomes community code to do the same work in their smart contracts, but it's very young still.

@shemnon shemnon merged commit cc7b420 into hashgraph:main Jul 12, 2022
@Nana-EC Nana-EC added this to the 0.1.0 milestone Oct 11, 2022
@Nana-EC Nana-EC added the enhancement New feature or request label Oct 12, 2022
georg-getz pushed a commit to georg-getz/hedera-smart-contracts that referenced this pull request Dec 12, 2022
@stoqnkpL @georg-getz
Default expiry modifier (hashgraph#4)
8208b1d 
* Rename helper functions
Add nonEmptyExpiry modifier to mirror sdks behaviour
Add createTokenWithDefaultExpiryAndEmptyKeys to TokenCreateContract examples

Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

@Nana-EC Nana-EC Nana-EC approved these changes

Assignees

@stoqnkpL stoqnkpL

Labels
enhancement New feature or request HTS Hedera Token Service related
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stoqnkpL @shemnon @Nana-EC