Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream Sourcify images as a dependency #147

Closed
13 tasks done
acuarica opened this issue Apr 5, 2024 · 0 comments · Fixed by #164
Closed
13 tasks done

Use upstream Sourcify images as a dependency #147

acuarica opened this issue Apr 5, 2024 · 0 comments · Fixed by #164
Assignees

Comments

@acuarica
Copy link
Contributor

acuarica commented Apr 5, 2024

Problem

Instead of maintaining our own fork of the verification service, use the images provided by upstream Sourcify directly. This will allow us to avoid duplicating efforts and incorporate new features easily.

For Hedera verification, we decided to directly consume server and repository images from Sourcify upstream. Given that the ui changes might be too Hedera specific, we decided to keep our ui fork with custom modifications.

Solution

The following is a list a features that upstream Sourcify should implement in order to use their images directly.

Server image

image

Repository image (and select-contract-form UI)

https://repository-verify.hashscan.io/select-contract/ vs https://repo.sourcify.dev/select-contract/

image

UI image just for completion, we continue to use our own fork

https://verify.hashscan.io/ vs https://sourcify.dev/#/verifier

Given that it might be more difficult to push our customizations in the UI, we might keep our fork of the UI. Thus, these issues are less relevant.

image image

Alternatives

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant