Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use upstream Sourcify images #164

Merged
merged 72 commits into from
May 28, 2024
Merged

feat: use upstream Sourcify images #164

merged 72 commits into from
May 28, 2024

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Apr 23, 2024 •
edited

Description:

This PR updates the configuration to consume upstream Sourcify images server and repository directly. We keep the ui image in this repo as it needs specific Hedera customizations. See #147 for more details.

The unused packages and src folders will be removed in PR #170 to ease the review of this one.

Related issue(s):

Fixes #147.
Fixes #141.
Fixes #145.
Fixes #101.
Fixes #98.
Fixes #97.
Fixes #89.

Notes for reviewer:

  • The compose.yaml provides a blueprint on how to build and run the images. Also it can be useful for development purposes.
  • The data folder is just a placeholder to mount repository contracts.
  • Most of the deleted files from the test folder were unused before this PR. These were removed here to avoid any future tech debt.
  • The tests that are left provide a last validation of Sourcify server.
  • There are now 2 patches, one for server and one for repository. This can be triggered from package.json.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica acuarica linked an issue Apr 23, 2024 that may be closed by this pull request
Use upstream Sourcify images as a dependency #147
Closed
13 tasks
@acuarica
Remove unused ARG TAG from ui
3639575 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Clean up unused ui build args in CI
bc87cbf 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Remove references to old env vars
291a363 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Move ui build into main hedera compose config
2d4c87f 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Use upstream Sourcify image locally
0d9b6de 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica acuarica force-pushed the 147-use-upstream-sourcify-images-as-a-dependency branch from e8c90a7 to 0d9b6de Compare April 24, 2024 16:21
@acuarica
Use better default for SERVER_URL in ui
c54b7a8 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Ignore files locally
71364af 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Add data placeholder folder to place repository contracts
4c2787b 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Clean up doc
b0064e7 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Apply new configuration for upstream Sourcify images
45d0852 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Remove server to use upstream Sourcify
441d632 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Remove server config files
2e95cd5 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Move tools to root
d7bd990 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Add upstream Sourcify to build and run server image
0a8f96d 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Update repo service to include bug fixes
0120af8 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Move setup to root
4766c68 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Remove lerna setup
d71fa14 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Use code fences for npm commands
16c4ec6 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Clean up git ignores
1a0529f 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Remove packages unit tests in CI
74dad9a 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Simplify compose
1de0270 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Remove unused dirty flag
1efd731 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Set up repository build to hide open in Remix link
92b92a9 
Moreover, it includes docs for the `SERVER_URL` env var

Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Remove envs
0095d70 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Clean up unused tests
fafb014 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Build new images in integration environment
c4e2315 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Fix integration workflow
c8c4541 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Restore old image name schema
7819571 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Revert "Remove server to use upstream Sourcify"
fc72eb3 
This reverts commit 441d632.

Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica acuarica marked this pull request as ready for review May 21, 2024 22:44
@acuarica acuarica requested review from a team as code owners May 21, 2024 22:44
@acuarica acuarica requested review from quiet-node, Sheng-Long, svienot and ericleponner and removed request for a team May 21, 2024 22:44
@acuarica acuarica mentioned this pull request May 22, 2024
Merged
Nana-EC
Nana-EC reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Just some validating questions

.github/workflows/release-integration.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
ui/public/config.json Show resolved Hide resolved
@acuarica
Normalize scripts naming
10a190a 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Address some Nana's comments
1bca8f9 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Improve Tools and Releases sections
893aa95 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Improve doc comments
29afdc6 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Improve docs
250943a 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Refine docs
a6d35eb 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
More on docs
b0292f8 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Refine docs
5c78f9e 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Move tools docs to own folder
819894a 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica
Fix typo
ebb441a 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Nana-EC
Nana-EC previously approved these changes May 28, 2024
View reviewed changes
@acuarica
Improve docs
99d3bcc 
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
svienot
svienot approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

server.patch Show resolved Hide resolved
servers.yaml Show resolved Hide resolved
@Nana-EC Nana-EC merged commit e313ed0 into main May 28, 2024
7 checks passed
@Nana-EC Nana-EC deleted the 147-use-upstream-sourcify-images-as-a-dependency branch May 28, 2024 16:42
@acuarica acuarica mentioned this pull request May 30, 2024
Closed
@acuarica acuarica added the enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label May 30, 2024
beeradb pushed a commit that referenced this pull request Jun 5, 2024
@acuarica @beeradb
feat: use upstream Sourcify images (#164)
c9125ef 
Signed-off-by: beeradb <294617+beeradb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

@Nana-EC Nana-EC Nana-EC left review comments

@quiet-node quiet-node Awaiting requested review from quiet-node quiet-node is a code owner automatically assigned from hashgraph/hedera-smart-contracts

@Sheng-Long Sheng-Long Awaiting requested review from Sheng-Long Sheng-Long is a code owner automatically assigned from hashgraph/dev-experience

@ericleponner ericleponner Awaiting requested review from ericleponner

Assignees
No one assigned
Labels
enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
Milestone
No milestone
3 participants
@acuarica @svienot @Nana-EC