Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace modifiedAgo property with template helper #323

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Replace modifiedAgo property with template helper #323

merged 6 commits into from
Sep 18, 2023

Conversation

jeffdaley
Copy link
Contributor

Replaces the computed modifiedAgo property from the Document model with template-calculated equivalents.

For now, this feels more ergonomic and Ember-like (until we use Ember Data).

@jeffdaley jeffdaley requested a review from a team as a code owner September 6, 2023 14:30
@jeffdaley jeffdaley mentioned this pull request Sep 6, 2023
Merged
@jeffdaley jeffdaley marked this pull request as draft September 6, 2023 14:42
@jeffdaley jeffdaley marked this pull request as ready for review September 8, 2023 01:15
This was referenced Sep 11, 2023
Merged
Merged
jfreda
jfreda approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jeffdaley jeffdaley merged commit 6674c89 into main Sep 18, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/modified-ago branch September 18, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda