Skip to content

Commit

Permalink
fix: Support empty secrets in OnDeleteStorageBucket
Browse files Browse the repository at this point in the history
  • Loading branch information
louisruch committed Aug 4, 2023
1 parent 62e885a commit 46b9666
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions plugin/service/storage/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,12 @@ func (p *StoragePlugin) OnDeleteStorageBucket(ctx context.Context, req *pb.OnDel
return nil, err
}

// NOTE: This check was added to support the Boundary 0.13.2 release as a hotfix for
// empty secrets. Future releases of the plugin will correctly handle empty secrets.
if req.GetPersisted().GetData() == nil {
return &pb.OnDeleteStorageBucketResponse{}, nil
}

// Get the persisted data.
// NOTE: We return on error here, blocking the delete. This may or
// may not be an overzealous approach to maintaining database/state
Expand Down

0 comments on commit 46b9666

Please sign in to comment.