Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already-canceled sessions return 200 #1243

Merged
merged 2 commits into from
May 21, 2021
Merged

Already-canceled sessions return 200 #1243

merged 2 commits into from
May 21, 2021

Conversation

jefferai
Copy link
Member

If a session is already canceled or terminated, attempting to cancel it
will return the current session state and a 200, instead of an error.

@jefferai jefferai added this to the 0.3.0 milestone May 19, 2021
If a session is already canceled or terminated, attempting to cancel it
will return the current session state and a 200, instead of an error.
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefferai jefferai merged commit a0c1f69 into main May 21, 2021
@jefferai jefferai deleted the jeff-cancel-200 branch May 21, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants