Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(authenticate): remove deprecated authenticate:login and credentials field #1534

Merged
merged 3 commits into from
Sep 18, 2021

Conversation

louisruch
Copy link
Collaborator

Removes authenticate:login as well as the deprecated credentials field in authenticate

@louisruch
Copy link
Collaborator Author

@jefferai @talanknight PTAL this removes deprecated fields from the authenticate domain
@randallmorey just confirming there will be no UI issues with this

@ghost
Copy link

ghost commented Sep 17, 2021

@louisruch can you summarise the change in plain English? I mostly understand the Go but want to confirm. It looks like the :authenticate:login endpoint goes away and the credentials field is removed.

@louisruch
Copy link
Collaborator Author

louisruch commented Sep 17, 2021

@louisruch can you summarise the change in plain English? I mostly understand the Go but want to confirm. It looks like the :authenticate:login endpoint goes away and the credentials field is removed.

@randallmorey yes, so the :authenticate:login endpoint was deprecated in 0.2.0 https://github.com/hashicorp/boundary/blob/main/CHANGELOG.md#deprecationschanges-4 this undoing the 0.1.6 deprecation of :authenticate
We also deprecated the credentials field in :authenticate to instead use attributes I believe this was done to support OIDC also see 0.2.0 changelog

@ghost
Copy link

ghost commented Sep 17, 2021

@louisruch can you summarise the change in plain English? I mostly understand the Go but want to confirm. It looks like the :authenticate:login endpoint goes away and the credentials field is removed.

@randallmorey yes, so the :authenticate:login endpoint was deprecated in 0.2.0 https://github.com/hashicorp/boundary/blob/main/CHANGELOG.md#deprecationschanges-4 this undoing the 0.1.6 deprecation of :authenticate
We also deprecated the credentials field in :authenticate to instead use attributes I believe this was done to support OIDC also see 0.2.0 changelog

Thank you. Approved! FE is on the latest.

ghost
ghost previously approved these changes Sep 17, 2021
jefferai
jefferai previously approved these changes Sep 17, 2021
@louisruch louisruch dismissed stale reviews from jefferai and ghost via 171751f September 17, 2021 22:20
@louisruch louisruch merged commit 6000f20 into main Sep 18, 2021
@louisruch louisruch deleted the louis-cleanup-auth branch September 18, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants