Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(authenticate): remove deprecated authenticate:login and credentials field #1534

Merged
merged 3 commits into from
Sep 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,19 @@

Canonical reference for changes, improvements, and bugfixes for Boundary.

## Next

### Deprecations/Changes

* Removes support for the `auth-methods/<id>:authenticate:login` action that was
deprecated in [Boundary 0.2.0](#020-20210414), please use
`auth-methods/<id>:authenticate` instead.
([PR](https://github.com/hashicorp/boundary/pull/1534)).
* Removes support for the `credential` field within `auth-methods/<id>:authenticate`
action. This field was deprecated in [Boundary 0.2.0](#020-20210414), please use
`attributes` instead.
([PR](https://github.com/hashicorp/boundary/pull/1534)).

## 0.6.1 (2021/09/14)

### Bug Fixes
Expand Down
1 change: 1 addition & 0 deletions internal/cmd/commands/server/listener_reload_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build !hsm
// +build !hsm

// NOTE on the NOTE: This is from Vault, but that doesn't mean it's not valid
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build !hsm
// +build !hsm

package server
Expand Down
1 change: 1 addition & 0 deletions internal/cmd/commands/server/worker_tags_reload_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build !hsm
// +build !hsm

// NOTE on the NOTE: This is from Vault, but that doesn't mean it's not valid
Expand Down
66 changes: 0 additions & 66 deletions internal/gen/controller.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -365,40 +365,6 @@
]
}
},
"/v1/auth-methods/{auth_method_id}:authenticate:login": {
"post": {
"summary": "Deprecated: Use Authenticate instead",
"operationId": "AuthMethodService_AuthenticateLogin",
"responses": {
"200": {
"description": "",
"schema": {
"$ref": "#/definitions/controller.api.resources.authtokens.v1.AuthToken"
}
}
},
"parameters": [
{
"name": "auth_method_id",
"description": "The ID of the Auth Method in the system that should be used for authentication.",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "body",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/controller.api.services.v1.AuthenticateLoginRequest"
}
}
],
"tags": [
"controller.api.services.v1.AuthMethodService"
]
}
},
"/v1/auth-methods/{id}": {
"get": {
"summary": "Gets a single Auth Method.",
Expand Down Expand Up @@ -5019,34 +4985,6 @@
}
}
},
"controller.api.services.v1.AuthenticateLoginRequest": {
"type": "object",
"properties": {
"auth_method_id": {
"type": "string",
"description": "The ID of the Auth Method in the system that should be used for authentication."
},
"token_type": {
"type": "string",
"description": "This can be \"cookie\" or \"token\". If not provided, \"token\" will be used. \"cookie\" activates a split-cookie method where the token is split partially between http-only and regular cookies in order\nto keep it safe from rogue JS in the browser."
},
"credentials": {
"type": "object",
"description": "Credentials are passed to the Auth Method; the valid keys and values depend on the type of Auth Method."
}
}
},
"controller.api.services.v1.AuthenticateLoginResponse": {
"type": "object",
"properties": {
"item": {
"$ref": "#/definitions/controller.api.resources.authtokens.v1.AuthToken"
},
"token_type": {
"type": "string"
}
}
},
"controller.api.services.v1.AuthenticateRequest": {
"type": "object",
"properties": {
Expand All @@ -5058,10 +4996,6 @@
"type": "string",
"description": "This can be \"cookie\" or \"token\". If not provided, \"token\" will be used. \"cookie\" activates a split-cookie method where the token is split partially between http-only and regular cookies in order\nto keep it safe from rogue JS in the browser."
},
"credentials": {
"type": "object",
"description": "Deprecated; use \"attributes\" instead."
},
"attributes": {
"type": "object",
"description": "Attributes are passed to the Auth Method; the valid keys and values depend on the type of Auth Method as well as the command."
Expand Down
679 changes: 236 additions & 443 deletions internal/gen/controller/api/services/auth_method_service.pb.go

Large diffs are not rendered by default.

124 changes: 0 additions & 124 deletions internal/gen/controller/api/services/auth_method_service.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions internal/gen/testing/event/event_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading