Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: bump deps to fix print styles #1628

Merged
merged 3 commits into from
Dec 3, 2021
Merged

website: bump deps to fix print styles #1628

merged 3 commits into from
Dec 3, 2021

Conversation

zchsh
Copy link
Contributor

@zchsh zchsh commented Oct 21, 2021

馃憖 Preview

This PR bumps dependencies in order to address @media print style issues. Specifically:

  • Bumps to latest @hashicorp/react-consent-manager, which hides itself in print media
  • Bumps to latest @hashicorp/react-subnav, which hides itself in print media
  • Removes now redundant project-level CSS intended to achieve the same.

Underlying component changes were made in hashicorp/react-components#406. Also bumps to updated consent-manager with changes here: hashicorp/react-components#407.

@zchsh
Copy link
Contributor Author

zchsh commented Oct 21, 2021

Before

before

After

after

@zchsh zchsh requested a review from mwickett October 21, 2021 20:52
@zchsh zchsh marked this pull request as ready for review October 21, 2021 20:52
mwickett
mwickett previously approved these changes Oct 22, 2021
@jefferai
Copy link
Member

jefferai commented Nov 5, 2021

@zchsh @mwickett Can one of you address the dep conflicts? Then I'd be happy to merge it. Thanks!

@zchsh
Copy link
Contributor Author

zchsh commented Dec 3, 2021

@mwickett @jefferai Ack, I totally dropped the ball on this one! I've just re-based and double-checked the styles again. Should be good to merge now 馃檱

@zchsh zchsh requested a review from mwickett December 3, 2021 14:53
@zchsh zchsh merged commit c43fa3f into main Dec 3, 2021
@zchsh zchsh deleted the zs.fix-print-styles branch December 3, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants