Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide subnav and consent-manager in print #406

Merged
merged 4 commits into from
Oct 19, 2021

Conversation

zchsh
Copy link
Contributor

@zchsh zchsh commented Oct 19, 2021

🎟️ Asana Task
πŸ” Preview Link


This PR updates @hashicorp/react-consent-manager and @hashicorp/react-subnav to ensure both components are hidden in print media.

  • fix(consent-manager): hide in print
  • fix(subnav): hide in print
  • chore(consent-manager): add changeset
  • chore(subnav): add changeset

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2021

πŸ¦‹ Changeset detected

Latest commit: 6dc0bd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hashicorp/react-subnav Patch
@hashicorp/react-consent-manager Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/4gbCUUT2SekpQFSkekw2ak2pJGmd
βœ… Preview: https://react-components-git-zshide-consent-manager-print-hashicorp.vercel.app

Comment on lines +6 to +8
@media print {
display: none;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove the need to write (often brittle) project-level CSS in every project, eg https://github.com/hashicorp/vault/blob/2bcd1c25c78cda3c25a2de6721e38625f0ec1e56/website/pages/print.css#L7

@zchsh zchsh requested a review from mwickett October 19, 2021 19:35
Copy link
Contributor

@mwickett mwickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Current react-components

CleanShot 2021-10-19 at 15 56 02@2x

This PR

CleanShot 2021-10-19 at 15 56 16@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants