-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hide subnav and consent-manager in print #406
Conversation
π¦ Changeset detectedLatest commit: 6dc0bd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). π Inspect: https://vercel.com/hashicorp/react-components/4gbCUUT2SekpQFSkekw2ak2pJGmd |
@media print { | ||
display: none; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove the need to write (often brittle) project-level CSS in every project, eg https://github.com/hashicorp/vault/blob/2bcd1c25c78cda3c25a2de6721e38625f0ec1e56/website/pages/print.css#L7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ποΈ Asana Task
π Preview Link
This PR updates
@hashicorp/react-consent-manager
and@hashicorp/react-subnav
to ensure both components are hidden in print media.PR Checklist π
Items in this checklist may not may not apply to your PR, but please consider each item carefully.