Backport of cmd: add CLI flags for proxy shutdown lifecycle management into release/1.0.x #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/proxy-lcm/shutdown/roughly-teaching-mongoose
branch
2 times, most recently
from
b6ff96e
to
13a41c0
Compare
hc-github-team-consul-core
force-pushed
the
backport/proxy-lcm/shutdown/roughly-teaching-mongoose
branch
from
323d624
to
1aebef3
Compare
curtbushko
approved these changes
Jun 27, 2023
hc-github-team-consul-core
deleted the
backport/proxy-lcm/shutdown/roughly-teaching-mongoose
branch
wilkermichael
pushed a commit
that referenced
this pull request
Jun 28, 2023
…t into release/1.0.x (#177) * backport of commit 9eaffd8 * backport of commit 8568158 * backport of commit e6f39b7 * backport of commit ecfe23f * backport of commit 04e73f2 * backport of commit bd4d480 * backport of commit c687111 --------- Co-authored-by: Mike Morris <mikemorris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #100 to be assessed for backporting due to the inclusion of the label backport/1.0.
The below text is copied from the body of the original PR.
Refs hashicorp/consul-k8s#536, hashicorp/consul-k8s#650
Adds the following CLI flags for proxy shutdown lifecycle management, disabled by default:
-shutdown-drain-listeners-shutdown-grace-periodAdds the following CLI flags for managing where the proxy lifecycle HTTP APIs are exposed:
-graceful-shutdown-path-graceful-portNotes for reviewers
pkg/consuldp/consul_dataplane_test.gohas tests exclusively for required configuration, should optional flags like those being added in this PR be tested somewhere else?envoy/proxy_test.golooks like a reasonable places to check the actual graceful shutdown behavior once implemented (and if enabled), but too broad a scope for just checking the flags set configuration properly.Should this wait to merge until the underlying functionality for these flags is implemented?-shutdown-delayCLI flag, do we care about the naming discrepancy? The implemented functionality may differ slightly because of how we'll be handling connection draining...Overview of commits