Add app-entrypoint command #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglass
force-pushed
the
pglass/app-entrypoint
branch
from
be6d810
to
49ccc3a
Compare
erichaberkorn
approved these changes
Nov 29, 2021
| t.Logf("Check the fake app process is still running") | ||
| proc, err := os.FindProcess(appPid) | ||
| require.NoError(t, err, "Failed to find fake app process") | ||
| // A zero-signal lets us check the process is still valid/running. |
There was a problem hiding this comment.
I'm surprised there isn't a better way to accomplish this, but this is fantastic
Co-authored-by: Eric Haberkorn <erichaberkorn@gmail.com>
lkysow
approved these changes
Nov 30, 2021
| return exitCode | ||
| } | ||
| if c.shutdownDelay > 0 { | ||
| c.log.Info(fmt.Sprintf("consul-ecs: received sigterm. waiting %s before terminating application.", c.shutdownDelay)) |
There was a problem hiding this comment.
can we include the datetime here or use hclog? Might be useful in any debugging situaton
There was a problem hiding this comment.
This is using hclog, so we get a timestamp:
2021-11-30T10:49:05.150-0600 [INFO] consul-ecs: received sigterm. waiting 5s before terminating application.
(Also, CloudWatch has its own timestamps)
There was a problem hiding this comment.
Ah nice, then can we use k/v logging instead of fmt.Sprintf?
There was a problem hiding this comment.
I guess for this log fmt.Sprintf reads better
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Add
app-entrypointsubcommand, which effectively supports delaying the TERM signal on Task shutdown for a certain amount of time.How I've tested this PR:
How I expect reviewers to test this PR:
馃憖
Checklist: