Remove consul binary from the consul-ecs docker image #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichaberkorn
force-pushed
the
remove-consul-binary
branch
2 times, most recently
from
7e4ae6b
to
ee174f4
Compare
2 tasks
This allows users to inject a consul binary into /bin/consul-inject
erichaberkorn
force-pushed
the
remove-consul-binary
branch
from
ee174f4
to
0a20419
Compare
erichaberkorn
requested review from
a team,
pglass and
ishustava
and removed request for
a team
lkysow
approved these changes
Oct 20, 2021
| @@ -23,13 +18,19 @@ ENV HASHICORP_RELEASES=https://releases.hashicorp.com | |||
|
|
|||
| # Create a non-root user to run the software. | |||
| RUN addgroup ${NAME} && \ | |||
| adduser -S -G ${NAME} ${NAME} | |||
| adduser -S -G ${NAME} ${NAME} && \ | |||
| # Changing the owner of /consul to NAME allows mesh-init to run as NAME rather | |||
ishustava
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
See hashicorp/terraform-aws-consul-ecs#53
How I expect reviewers to test this PR:
👁️
Checklist: