Image pull secrets

[lkysow]

Allow setting image pull secrets for service accounts to enable pulling the consul-k8s and consul images from private registries.

Kube docs: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-imagepullsecrets-to-a-service-account

Notes

• Refactors work from Added Image pull secret to all service Accounts #402 (thanks!!)
• Closes Added Image pull secret to all service Accounts #402
• Closes Add imagePullSecrets to DaemonSets #270

[adilyse]

Looking good. The one thing I noticed is that the value is defined as an array, but all of the tests only test a single value. It'd be good to make sure that the iteration through multiple values works as expected too.

[adilyse]

These example feels confusing. When empty, the value needs [], but it doesn't need them when I give a value? In the extraConfig text we mention that it's an array of objects, which might help a bit.

[lkysow]

Yeah good call, changed to say "array of objects containing image pull secret names"

[lkysow]

The one thing I noticed is that the value is defined as an array, but all of the tests only test a single value. It'd be good to make sure that the iteration through multiple values works as expected too.

For sure. I've changed the tests to set two image pull secrets and assert that both are set.

[adilyse]

Generally when we're testing for several values, each one is checked separately. Example: env variable

[adilyse]

One more question-- should these be quoted? From the docs, it looks like they're not being quoted:

imagePullSecrets:
- name: myregistrykey

[lkysow]

It doesn't matter, it's just a string.

[adilyse]

Looks good.

Though if the quoting doesn't matter, it's a little odd to go to the effort to add it.

[lkysow]

Yeah I'll remove it.