Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Update resource settings for the lifecycle sidecar and init containers for the gateway deployment templates #533

Merged
merged 2 commits into from Jul 9, 2020

Conversation

kschoche
Copy link
Contributor

@kschoche kschoche commented Jul 9, 2020

currently the gateways do not have resource settings for their lifecycle sidecars and the resource settings for the init container which issues a cp of the consul binary has resource settings which are too low.

This PR :

  1. adds the resource settings for the lifecycle sidecar, increases the lifecycle sidecar cpu settings from 10m to 20m
  2. adds the resource settings for the init container which copies the consul bin and increases the memory limits only from the respective pod deployments to 150Mi only for the init container.

@kschoche kschoche added bug Something isn't working enhancement New feature or request labels Jul 9, 2020
@kschoche kschoche changed the title Update resources gws Update resource settings for the lifecycle sidecar and init containers for the gateway deployment templates Jul 9, 2020
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested mesh, ingress and terminating gateways alongside your consul-k8s changes for inject and all the resources are set correctly!

@kschoche kschoche merged commit f63f02f into master Jul 9, 2020
@kschoche kschoche deleted the update_resources_gws branch July 9, 2020 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants