This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
make sync-catalog work with clients disabled #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the sync-catalog won't work when the clients are disable because of the use of `HOST_IP` to connect to the service. I propose that when clients are disable, the synccatalog falls back to the consul server service.
|
|
lkysow
suggested changes
Aug 12, 2020
There was a problem hiding this comment.
Thanks for the PR! Can you also write tests please? See https://github.com/hashicorp/consul-helm/blob/master/CONTRIBUTING.md#writing-unit-tests.
lkysow
added
area/chart-only
When `client.enabled=true` the syncCatalog should make use of the HOST_IP to connect with consul. When `client.enabled=false` the syncCatalog should fall back to the consul server service.
lkysow
approved these changes
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sync-catalog won't work when clients are disabled (see #211 ). I'm opening this PR because we have a use case (running multiple consuls) where we disable clients and prefer working with the kubernetes service instead.
The sync-catalog won't work with the clients disabled due to the use of the
HOST_IPvariable. Since the option is given to disable the clients, I think the logic would go that if the clients are disabled, the sync-catalog talks to the kubernetes service for the consul server instead of interacting through the clients.It has some duplicate code and I'm not sure if this is the best way, but it has been confirmed to work when deploying our application set.
Feel free to make any suggestions, I mainly want to see #211 resolved.