Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add support for changing the Consul node name where services are sync'd #580

Merged
merged 3 commits into from Sep 9, 2020

Conversation

adilyse
Copy link
Contributor

@adilyse adilyse commented Aug 19, 2020

No description provided.

@adilyse adilyse marked this pull request as ready for review August 21, 2020 17:11
@adilyse adilyse requested review from a team, lkysow and kschoche and removed request for a team August 21, 2020 17:11
values.yaml Show resolved Hide resolved
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, great work!
One minor suggestion that is not blocking.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tested it out with ACLs and the new k8s docker image.

@ishustava ishustava added area/sync Related to catalog sync enhancement New feature or request labels Sep 9, 2020
@ishustava ishustava merged commit 039b171 into master Sep 9, 2020
@ishustava ishustava deleted the feature/name-k8s-node branch September 9, 2020 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/sync Related to catalog sync enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants