This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
envoy versioning is now set at the global level #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoche
requested review from
a team,
lkysow and
ishustava
and removed request for
a team
kschoche
added
area/connect
ishustava
reviewed
Aug 27, 2020
There was a problem hiding this comment.
That's awesome! Thanks for making this change 🙏
I left a couple of edits. I'm also now thinking about whether we should keep the behavior when you set imageEnvoy to null for connect? Since we're consolidating it into one property, I think it'd make sense for it to behave the same way across connect and gateways. What do you think?
I'm also curious if you have thought about what to do with the default in consul-k8s. Since we're making this change and it'll be a breaking change, would it makes sense to also make a breaking change in consul-k8s and remove the default?
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
lkysow
reviewed
Aug 28, 2020
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
kschoche
commented
Aug 28, 2020
lkysow
reviewed
Aug 28, 2020
lkysow
approved these changes
Aug 28, 2020
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
ishustava
approved these changes
Aug 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove meshGateway.imageEnvoy and connectInject.imageEnvoy in favour of global.imageEnvoy which is what ingress and terminating gateways use, this will standardize imageEnvoy across all the gateways and connectInject.
Note : we are removing the option to leave
connectInject.imageEnvoy: "null"