This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Provide a valid maxUnavailable value when using a single replica #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a condition to set `maxUnavailable` to 0 when replicas=1. Previously, the logic returned an invalid value of `-1`. The larger issue of not being able to set something explicitly to 0 remains, as this is a limitation of the way helm templating works. For more information, see: Helm documentation that a numerical 0 is treated identically to null: https://docs.helm.sh/chart_template_guide/#if-else Github issue for this: helm/helm#3164
This was referenced Nov 10, 2018
|
@adilyse I am sure it was an interesting journey to this PR! |
anubhavmishra
approved these changes
Nov 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a condition to set
maxUnavailableto 0 when replicas=1.Previously, the logic returned an invalid value of
-1. (See #58 )The larger issue of not being able to set something explicitly to 0
remains, as this is a limitation of the way helm templating works.
For more information, see:
Helm documentation that a numerical 0 is treated identically to null:
https://docs.helm.sh/chart_template_guide/#if-else
Github issue for this:
helm/helm#3164
Additionally cleans up some test descriptions for greater clarity.