This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Pass server resource limits on to the pods in the stateful set #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values.yaml allowed users to define resource limitations for the server pods, but was not applying these to the pods in the server-statefulset.yaml. This fixes that oversight.
These values now default to null and are optional in the template files. Adds tests for the new values. Also changes the file extension on several of the test files from .yaml to .bats.
adilyse
force-pushed
the
bugfix/server-resources
branch
from
64c498b
to
2bfcb1c
Compare
adilyse
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values.yaml allowed users to define resource limitations for
the server pods, but was not applying these to the pods in the
server-statefulset.yaml. This fixes that oversight.
Switches the
resourcesdefinitions to be optional multi-linestrings to match the same formatting as
affinity. Adds testsfor the resource definitions.
Updates several test file extensions from
.yaml. to.bats.Rearranges the order of tests in the
server-statefulset.yamlfile to match the ordering in the values file.