This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
feat: Customizable command-line option "node-meta" to the agent #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-froes-ifood
approved these changes
Dec 4, 2020
|
Thanks for the PR! Can you add unit tests please (see https://github.com/hashicorp/consul-helm/blob/master/CONTRIBUTING.md#writing-unit-tests). Specifically I think we need cases for:
|
carnei-ro
force-pushed
the
feat/client-nodeMeta
branch
from
52dc33b
to
98cf2ab
Compare
drequena
approved these changes
Dec 10, 2020
carnei-ro
force-pushed
the
feat/client-nodeMeta
branch
from
98cf2ab
to
efb43e8
Compare
thisisnotashwin
approved these changes
Jul 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow receive map to customize the Metadata section of the Node (consul agent).