This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Deprecate connectInject.centralConfig #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
deprecate-central-config
branch
4 times, most recently
from
3c99936
to
e33b7f0
Compare
2 tasks
lkysow
force-pushed
the
deprecate-central-config
branch
from
e33b7f0
to
839299f
Compare
|
I forgot to add the |
.circleci/config.yml
Outdated
| @@ -154,7 +154,7 @@ jobs: | |||
| -kubecontext="kind-dc1" \ | |||
| -secondary-kubecontext="kind-dc2" \ | |||
| -debug-directory="$TEST_RESULTS/debug" \ | |||
| -consul-k8s-image=hashicorpdev/consul-k8s:latest | |||
| -consul-k8s-image=ghcr.io/lkysow/consul-k8s-dev:jan11 | |||
There was a problem hiding this comment.
just a reminder to delete this pre-merging
lkysow
commented
Jan 13, 2021
I've added this removal now. |
ishustava
reviewed
Jan 22, 2021
There was a problem hiding this comment.
This looks good! My only comment that I think is currently blocking is about handling a case when .Values.connectInject.centralConfig is set to true. This could be the case if you are super explicit in your helm config and still set it, even though the default was true.
ishustava
approved these changes
Jan 22, 2021
lkysow
force-pushed
the
deprecate-central-config
branch
from
1c0b30e
to
059f06e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
connectInject.centralConfig.defaultProtocol. Use of this setting will now cause an error onhelm upgrade.connectInject.centralConfig.proxyDefaults. Use of this setting will now cause an error onhelm upgrade.connectInject.centralConfig.enabledtofalse. Its default was previouslytruebut we did allow you to set it tofalseif you weren't using connect inject. Now you can't set it at all and we default it to true. Consul made the defaulttruein 1.9.0 and removing the ability to set it tofalsein the Helm chart lets us fully remove theconnectInject.centralConfigblock. Users can still set it to false viaextraConfig.meshGateway.globalMode. Use of this setting will now cause an error onhelm upgrade.How I've tested this PR:
connect-inject-deployment.batsbecause that's where thefailcommands are.centralConfig.enabledtofalseand kept the tests that ensure it's set to true by default.How I expect reviewers to test this PR:
Checklist: