Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

use non-root folder to create apply-license script #880

Merged
merged 1 commit into from Mar 31, 2021

Conversation

osdemah
Copy link
Contributor

@osdemah osdemah commented Mar 22, 2021

Changes proposed in this PR:

  • Use /tmp/scripts folder instead of the WORKDIR which is / to avoid getting permission denied errors when security context defaults to the non-root users

How I've tested this PR:

  • I installed the helm chart with enterprise license on a k8s cluster that doesn't allow root user in security context by default and made sure the job runs Ok.

How I expect reviewers to test this PR:

  • Inatall the helm chart in an openshift cluster with enterprise license and compare the pre-PR and post-PR behavior. The chart gets failed with permission denied error as openshift assigns a non-root user to the pods by default.

Checklist:

  • Bats tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 22, 2021

CLA assistant check
All committers have signed the CLA.

@david-yu
Copy link
Contributor

david-yu commented Mar 22, 2021

Hi @osdemah thank you for being a customer and we appreciate the PR. We might need to add some Bats tests to make sure that this is caught in our CI.

@kschoche kschoche added the bug Something isn't working label Mar 26, 2021
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for the PR.

I tested it out and the license applied as expected.

@lkysow lkysow merged commit 3b631ad into hashicorp:master Mar 31, 2021
lkysow added a commit that referenced this pull request Mar 31, 2021
lkysow added a commit that referenced this pull request Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants