This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Allow unstructed schema for config in ProxyDefaults #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
changed the title
2 tasks
thisisnotashwin
approved these changes
Apr 20, 2021
ishustava
requested review from
a team,
lkysow and
ndhanushkodi
and removed request for
a team and
lkysow
lkysow
reviewed
Apr 20, 2021
| @@ -92,6 +92,10 @@ func TestController(t *testing.T) { | |||
| proxyDefaultEntry, ok := entry.(*api.ProxyConfigEntry) | |||
| require.True(r, ok, "could not cast to ProxyConfigEntry") | |||
| require.Equal(r, api.MeshGatewayModeLocal, proxyDefaultEntry.MeshGateway.Mode) | |||
| require.Equal(r, "tcp", proxyDefaultEntry.Config["protocol"]) | |||
There was a problem hiding this comment.
let's also test foo and member for completeness. Or we can remove those from the fixture. I like testing multiple types, so maybe bool, array, map, string?
There was a problem hiding this comment.
Hmm, good call. I think I've made an assumption that these are going to be ignored by consul, but they're not!
lkysow
approved these changes
Apr 20, 2021
ndhanushkodi
approved these changes
Apr 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see hashicorp/consul-k8s#495 for details about why this change is needed
Changes proposed in this PR:
configfield, we're not setting all acceptable values but I think it's OK since we're trying to check that at least one is accepted by Consul.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: