This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Add ability to set log level and enable json logging for all consul-k8s commands #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoche
changed the title
kschoche
requested review from
a team,
lkysow and
ndhanushkodi
and removed request for
a team
2 tasks
kschoche
commented
Jun 22, 2021
lkysow
reviewed
Jun 28, 2021
lkysow
approved these changes
Jun 29, 2021
|
Should we have a follow-up PR that sets the log level/json for Consul clients/servers too? |
Yup this was only for subcommands. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
global.logJSONglobal.logLevelNOTES:
How I've tested this PR:
unit tests, acceptance tests pass
How I expect reviewers to test this PR:
code review, acceptance tests pass
Also have manually testing using steps in hashicorp/consul-k8s#523
Checklist: