Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add support for recursor flag #985

Merged
merged 5 commits into from
Jun 10, 2021
Merged

Add support for recursor flag #985

merged 5 commits into from
Jun 10, 2021

Conversation

m-yosefpor
Copy link
Contributor

@m-yosefpor m-yosefpor commented Jun 10, 2021

Fixes: #984

Changes proposed in this PR:

How I've tested this PR: Yes, provided in next section.

How I expect reviewers to test this PR:

  1. Default value should not change any manifests. i.e.
global:
    recursors: null
  1. Setting a list of IP addresses, will provide the flag to server and clients, and user should be able to resolve queries recursively.
global:
   recursors:
   - 8.8.8.8
   - 1.1.1.1

Looking up a domain outside of consul domain in agents, and servers should return IP address:

$ kubectl exec consul-74tmn --  nslookup google.com localhost:8600
Server:         localhost:8600
Address:        [::1]:8600

Name:   google.com
Address: 142.251.37.14

Non-authoritative answer:
Name:   google.com
Address: 2a00:1450:400e:808::200e
$ kubectl exec consul-server-0 -- nslookup google.com localhost:8600
Server:         localhost:8600
Address:        [::1]:8600

Name:   google.com
Address: 142.251.37.14

Non-authoritative answer:
Name:   google.com
Address: 2a00:1450:400e:808::200e

Checklist:

  • Bats tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 10, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple small suggestions.

test/unit/client-daemonset.bats Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
m-yosefpor and others added 2 commits June 10, 2021 23:35
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
@m-yosefpor
Copy link
Contributor Author

@lkysow Thanks for your review. Suggestions applied.

@m-yosefpor m-yosefpor requested a review from lkysow June 10, 2021 19:08
@lkysow lkysow merged commit c528876 into hashicorp:master Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add -recursor flag
3 participants