Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Kubernetes versions to existing +2 for clouds #1852

Merged
merged 3 commits into from Jan 27, 2023
Merged

Bump Kubernetes versions to existing +2 for clouds #1852

merged 3 commits into from Jan 27, 2023

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Jan 26, 2023 •
edited

Changes proposed in this PR:

  • Bump the version of K8s on the pipelines

How I've tested this PR:

How I expect reviewers to test this PR:
look at them pipelines and how pretty and green they are and then hit approve 馃槢

@thisisnotashwin thisisnotashwin force-pushed the ashwin/upgrade-k8s-versions-acceptance branch 3 times, most recently from 57ea1b7 to 484b353 Compare January 26, 2023 15:38
@david-yu
Copy link
Contributor

I assume kind will be also be bumped to 1.26? Is that in a separate PR perhaps?

@thisisnotashwin
Copy link
Contributor Author

I assume kind will be also be bumped to 1.26? Is that in a separate PR perhaps?

Currently, Kind does not have 1.26 support. https://github.com/kubernetes-sigs/kind/releases here lists 1.25 as the latest supported one. We will bump to the latest kind as soon as it is released.

@thisisnotashwin thisisnotashwin force-pushed the ashwin/upgrade-k8s-versions-acceptance branch from 484b353 to b6d1042 Compare January 26, 2023 18:40
@david-yu
Copy link
Contributor

Ahh I just saw this https://twitter.com/BenTheElder/status/1601280095184117760, it looks like its possible to use 1.26.x but not sure its been used before this way for us.

@thisisnotashwin thisisnotashwin force-pushed the ashwin/upgrade-k8s-versions-acceptance branch from cd3284a to 39f616c Compare January 26, 2023 20:21
@thisisnotashwin thisisnotashwin requested review from ishustava, a team, curtbushko and DanStough and removed request for a team January 26, 2023 23:30
@thisisnotashwin thisisnotashwin marked this pull request as ready for review January 26, 2023 23:30
@thisisnotashwin
Copy link
Contributor Author

Updated kind as well to 1.26.

I have disabled pod security policies for now. we need some further investigations into what it's future looks like given it isn't currently supported. that can be done in the future as another independent PR.

curtbushko
curtbushko approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at that fancy terraform! 馃槏

.circleci/config.yml
@@ -773,7 +773,7 @@ jobs:
- run: mkdir -p $TEST_RESULTS

- run-acceptance-tests:
additional-flags: -kubeconfig="$primary_kubeconfig" -secondary-kubeconfig="$secondary_kubeconfig" -enable-pod-security-policies -enable-transparent-proxy -consul-image=hashicorppreview/consul-enterprise:1.15-dev-23aaa4f83845d0e2eced9ea69f731d7eedf840d1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does -pod-security-policies break things on the new versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes no longer supports pod security policies starting 1.25. https://kubernetes.io/blog/2021/04/06/podsecuritypolicy-deprecation-past-present-and-future/

@thisisnotashwin
Copy link
Contributor Author

Should we backport this to 0.49.x? (it doesn't matter as much because those only run against GKE)

@thisisnotashwin thisisnotashwin added the theme/testing Related to testing label Jan 27, 2023
DanStough
DanStough approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing 馃殌

ishustava
ishustava approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Ashwin! Thank you for fixing it. I left a few comments but they are not blocking.

charts/consul/test/terraform/eks/main.tf Show resolved Hide resolved
charts/consul/test/terraform/gke/main.tf Outdated
Comment on lines 31 to 33
pod_security_policy_config {
enabled = true
enabled = false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we can just remove this config altogether since it's not enabled by default. Another thing here is that we can switch the google provider regular instead of beta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do!

@ishustava
Copy link
Member

@thisisnotashwin we'll also need to update readme and add it to Changelog.

@thisisnotashwin thisisnotashwin force-pushed the ashwin/upgrade-k8s-versions-acceptance branch from 39f616c to fc34136 Compare January 27, 2023 16:32
@thisisnotashwin thisisnotashwin merged commit d47cfd3 into main Jan 27, 2023
@thisisnotashwin thisisnotashwin deleted the ashwin/upgrade-k8s-versions-acceptance branch January 27, 2023 16:41
@thisisnotashwin thisisnotashwin mentioned this pull request Jan 27, 2023
Closed
thisisnotashwin added a commit that referenced this pull request Jan 27, 2023
@thisisnotashwin
Bump Kubernetes versions for clouds for acceptance tests (#1852)
f4617be
thisisnotashwin added a commit that referenced this pull request Jan 27, 2023
@thisisnotashwin
Bump Kubernetes versions for clouds for acceptance tests (#1852) (#1855)
3ca55e7
jm96441n pushed a commit that referenced this pull request Feb 2, 2023
@thisisnotashwin @jm96441n
Bump Kubernetes versions for clouds for acceptance tests (#1852)
1361c73
jm96441n pushed a commit that referenced this pull request Feb 2, 2023
@thisisnotashwin @jm96441n
Bump Kubernetes versions for clouds for acceptance tests (#1852)
f48b555
david-yu pushed a commit that referenced this pull request Feb 14, 2023
@thisisnotashwin @david-yu
Bump Kubernetes versions for clouds for acceptance tests (#1852)
371cd23
ishustava pushed a commit that referenced this pull request Feb 18, 2023
@thisisnotashwin @ishustava
Bump Kubernetes versions for clouds for acceptance tests (#1852)
9d6e0aa
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@curtbushko curtbushko curtbushko approved these changes

@DanStough DanStough DanStough approved these changes

Assignees
No one assigned
Labels
backport/1.0.x theme/testing Related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thisisnotashwin @david-yu @ishustava @curtbushko @DanStough