Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual backport of #2078 #2133

Merged
merged 7 commits into from
May 15, 2023
Merged

Manual backport of #2078 #2133

merged 7 commits into from
May 15, 2023

Conversation

hanshasselberg
Copy link
Member

This is a manual backport of 2078, because the automatic PR #2120 did not succeed.

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@hanshasselberg hanshasselberg marked this pull request as ready for review May 15, 2023 09:34
@hanshasselberg hanshasselberg added the pr/no-backport signals that a PR will not contain a backport label label May 15, 2023
@curtbushko curtbushko self-requested a review May 15, 2023 14:07
curtbushko
curtbushko approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hans! :shakesfistatbackportassistant:

@hanshasselberg hanshasselberg merged commit ec87da7 into release/1.0.x May 15, 2023
@hanshasselberg hanshasselberg deleted the hans/manual_backport_2078 branch May 15, 2023 14:21
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@ndhanushkodi ndhanushkodi Awaiting requested review from ndhanushkodi

Assignees
No one assigned
Labels
pr/no-backport signals that a PR will not contain a backport label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanshasselberg @curtbushko