connect: skip service registration only for duplicate services on k8s #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
added
type/bug
ishustava
requested review from
a team,
ndhanushkodi and
kschoche
and removed request for
a team
ishustava
commented
Jul 30, 2021
ndhanushkodi
approved these changes
Aug 2, 2021
ishustava
force-pushed
the
ishustava/skip-service-reg-fix
branch
from
7efe643
to
67bb890
Compare
…re on k8s Previously, we would skip service registration if we find a duplicate service even when the 'k8s-namespace' meta key is not present on the service. However, that is not correct behavior since that would ignore any service instance that could exist on other platforms (e.g. VMs) and that doesn't have this meta key. We should instead only check services that have the 'k8s-namespace' meta key.
ishustava
force-pushed
the
ishustava/skip-service-reg-fix
branch
from
67bb890
to
af0b16f
Compare
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would skip service registration if we find a duplicate service
even when the 'k8s-namespace' meta key is not present on the service.
However, that is not correct behavior since that would ignore any service
instance that could exist on other platforms (e.g. VMs) and that
doesn't have this meta key. We should instead only check services that
have the 'k8s-namespace' meta key.
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: