Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: skip service registration only for duplicate services on k8s #581

Merged
merged 1 commit into from
Aug 2, 2021

Commits on Aug 2, 2021

  1. connect: skip service registration only for duplicate services that a…

    …re on k8s
    
    Previously, we would skip service registration if we find a duplicate service
    even when the 'k8s-namespace' meta key is not present on the service.
    However, that is not correct behavior since that would ignore any service
    instance that could exist on other platforms (e.g. VMs) and that
    doesn't have this meta key. We should instead only check services that
    have the 'k8s-namespace' meta key.
    ishustava committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    af0b16f View commit details
    Browse the repository at this point in the history