Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set default retry count #121

Merged
merged 1 commit into from
Oct 20, 2020
Merged

set default retry count #121

merged 1 commit into from
Oct 20, 2020

Conversation

findkim
Copy link
Contributor

@findkim findkim commented Oct 19, 2020

I think the worker retry #72 was somehow missed in the refactor efforts #81. defaultRetry is 2 and was used in #72 and no longer referenced anywhere after #81

@findkim findkim added the bug Something isn't working label Oct 19, 2020
lornasong
lornasong approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! thanks for catching this :)

@findkim findkim merged commit ff92be2 into master Oct 20, 2020
@findkim findkim deleted the worker-retry branch October 20, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornasong lornasong lornasong approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findkim @lornasong